8271063: Print injected fields for InstanceKlass

[coleenp]

I added code to print the injected fields in InstanceKlass. I also removed field offset sorting for do_nonstatic_fields because it's not necessary when used for purposes other than printing the fields. I also added a gtest.
Tested with tier1 all Oracle platforms, tier2-3 on linux-x64-debug, windows-x64-debug.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8271063: Print injected fields for InstanceKlass

Reviewers

• Frederic Parain (@fparain - Committer) ⚠️ Review applies to 7f8e742
• Harold Seigel (@hseigel - Reviewer) ⚠️ Review applies to 7f8e742
• Yi Yang (@kelthuzadx - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4858/head:pull/4858
$ git checkout pull/4858

Update a local copy of the PR:
$ git checkout pull/4858
$ git pull https://git.openjdk.java.net/jdk pull/4858/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4858

View PR using the GUI difftool:
$ git pr show -t 4858

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4858.diff

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (d7f648a0)
• 02: Full - Incremental (7f8e7421)
• 01: Full - Incremental (4c86b5c4)
• 00: Full (38e8b907)

[fparain]

Looks good to me.

Fred

[coleenp]

Thanks Fred!

[hseigel]

Changes look good!
Thanks, Harold

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271063: Print injected fields for InstanceKlass

Reviewed-by: fparain, hseigel, yyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 51 new commits pushed to the master branch:

• 9935440: Merge
• e3800e6: 8271162: runtime/StackTrace/LargeClassTest.java can be run in driver mode
• ee93cef: 8271158: runtime/handshake/HandshakeTimeoutTest.java test doesn't check exit code
• 84be910: 8271169: runtime/Safepoint/TestAbortVMOnSafepointTimeout.java can be run in driver mode
• 2d165a2: 8271160: runtime/jni/checked/TestCheckedJniExceptionCheck.java doesn't set -Djava.library.path
• 7165b3f: 8271155: Wrong path separator in env variable
• ecc37b0: 8270916: Update java.lang.annotation.Target for changes in JLS 9.6.4.1
• 4812e53: 8271094: runtime/duplAttributes/DuplAttributesTest.java doesn't check exit code
• 6a9ab6a: 8271093: remove deadcode from runtime/Thread/TestThreadDumpSMRInfo.java test
• e7f9009: 8270085: Suspend during block transition may deadlock if lock held
• ... and 41 more: https://git.openjdk.java.net/jdk/compare/cd8783c08ee18167f15df621e997015b971bfb01...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[coleenp]

Thanks Harold!

[y1yang0]

Looks good, thanks for doing this.

[coleenp]

Thanks for the review and suggestion.
/integrate

[openjdk]

Going to push as commit 9b27df6.
Since your change was applied there have been 58 commits pushed to the master branch:

• 0cc4bb7: 8270870: Simplify G1ServiceThread
• 8c8e3a0: 8271163: G1 uses wrong degree of MT processing since JDK-8270169
• 8a789b7: 8263840: PeriodicTask should declare its destructor virtual
• f226190: 8270894: Use acquire semantics in ObjectSynchronizer::read_stable_mark()
• ea182b5: 8271060: Merge G1CollectedHeap::determine_start_concurrent_mark_gc and G1Policy::decide_on_conc_mark_initiation
• fb85960: 8271149: remove unreferenced functions from EncodingSupport_md.c
• 8156ff6: 8271147: java/nio/file/Path.java javadoc typo
• 9935440: Merge
• e3800e6: 8271162: runtime/StackTrace/LargeClassTest.java can be run in driver mode
• ee93cef: 8271158: runtime/handshake/HandshakeTimeoutTest.java test doesn't check exit code
• ... and 48 more: https://git.openjdk.java.net/jdk/compare/cd8783c08ee18167f15df621e997015b971bfb01...master

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit 9b27df6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.