Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271043: Rename G1CollectedHeap::g1mm() #4859

Closed
wants to merge 1 commit into from

Conversation

@tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Jul 21, 2021

Hi all,

can I have reviews for this change that renames the somewhat cryptic name g1mm with monitoring_support which sounds much better to me.
Feel free to suggest a better name or if you think it's not worth I can also just drop this change.

Testing: tier1-5


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4859/head:pull/4859
$ git checkout pull/4859

Update a local copy of the PR:
$ git checkout pull/4859
$ git pull https://git.openjdk.java.net/jdk pull/4859/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4859

View PR using the GUI difftool:
$ git pr show -t 4859

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4859.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 21, 2021

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jul 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 21, 2021

@tschatzl The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 21, 2021

Webrevs

Copy link

@kimbarrett kimbarrett left a comment

Looks good.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 21, 2021

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271043: Rename G1CollectedHeap::g1mm()

Reviewed-by: kbarrett, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 21, 2021
Copy link
Member

@walulyai walulyai left a comment

lgtm!

@tschatzl
Copy link
Contributor Author

@tschatzl tschatzl commented Jul 22, 2021

Thanks @kimbarrett @walulyai for your reviews

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 22, 2021

Going to push as commit 8e27d4e.
Since your change was applied there have been 29 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 22, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 22, 2021
@tschatzl tschatzl deleted the submit/8271043-rename-g1mm branch Jul 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 22, 2021

@tschatzl Pushed as commit 8e27d4e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants