8253876: jdk/test/lib/hexdump/ASN1FormatterTest.java fails with "AssertionError: Lines expected [126] but found [202]" #486
Conversation
|
👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into |
|
@RogerRiggs The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
RogerRiggs
changed the title
Webrevs
|
There was a problem hiding this comment.
I am puzzled about this change. I feels weird to drop proper line separator from ASN1Formatter to please the test. And it does not even look complete, because ASN1Formatter still uses String.format("...%n", ...) sometimes, that still uses system line separator.
Can the test be made resilient by watching out for lineSeparator(), instead of just \n?
|
The real fix for the test failing was the change in HexPrinter to ignore the when it is breaking lines from the formatter. However, since the formatters can be used independently of HexPrinter, they should use System.lineSeparator() to work consistently. I'll put back the System.lineSepartor() use and re-test. |
| @@ -166,7 +166,8 @@ private int annotate(DataInputStream in, Appendable out, int available, String p | |||
| int nbytes = len & 0x7f; | |||
| if (nbytes > 4) { | |||
| out.append("***** Tag: " + tagName(tag) + | |||
| ", Range of length error: " + len + " bytes" + System.lineSeparator()); | |||
| ", Range of length error: " + len + " bytes"); | |||
There was a problem hiding this comment.
I think you can break this line into append-s, while we are at it. But your choice.
|
@RogerRiggs This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 51 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
openjdk
bot
added
integrated
|
@RogerRiggs Since your change was applied there have been 51 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 38159d5. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The HexPrinter test utility should be ignoring \r characters from the formatter.
It looks for \n and generates System.lineSeparator() at the end of each line.
With this fix, the ASN1FormatterTest can be removed from the ProblemList.
Progress
Testing
Failed test task
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/486/head:pull/486$ git checkout pull/486