8225313: serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatObjectCorrectnessTest.java failed with Unexpected high difference percentage

[lmesnik]

Fixed as suggested (increasing accepted error rate and a number of iteration). Verified by 2000 runs in our CI lab.The average test execution time ~5s. The bugs in the problemlist are duplicates of this issue.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8225313: serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatObjectCorrectnessTest.java failed with Unexpected high difference percentage

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Kevin Walls (@kevinjwalls - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4864/head:pull/4864
$ git checkout pull/4864

Update a local copy of the PR:
$ git checkout pull/4864
$ git pull https://git.openjdk.java.net/jdk pull/4864/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4864

View PR using the GUI difftool:
$ git pr show -t 4864

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4864.diff

[bridgekeeper]

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[lmesnik]

The method is not implemented and not used.

[openjdk]

@lmesnik The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (e62c22a9)
• 01: Full - Incremental (b9c185cf)
• 00: Full (8f2e1a99)

[dholmes-ora]

Hi Leonid,

These changes seem quite reasonable.

There is a comment in HeapMonitorStatIntervalTest.java that still refers to a 10% threshhold.

Thanks,
David

[openjdk]

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8225313: serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatObjectCorrectnessTest.java failed with Unexpected high difference percentage

Reviewed-by: dholmes, kevinw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

• 9131a8f: 8267940: [macos] java/awt/print/Dialog/DialogOwnerTest.java fails
• 6096dd9: 8268893: jcmd to trim the glibc heap
• c36755d: Merge
• 89f7998: 8266347: assert(Dependencies::is_concrete_root_method(fm, ctxk) == Dependencies::is_concrete_method(m, ctxk)) failed: mismatch
• e1051ae: 8264066: Enhance compiler validation
• add995b: 8265201: JarFile.getInputStream not validating invalid signed jars
• ca6b222: 8258432: Improve File Transfers
• a3acce5: 8264079: Improve abstractions
• 138f598: 8262380: Enhance XML processing passes
• 0e6c011: 8262967: Improve Zip file support
• ... and 12 more: https://git.openjdk.java.net/jdk/compare/0790f04d8a41aa61b4633e822120d913ec89d900...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dholmes-ora]

Update looks good.

Thanks.

[lmesnik]

testing shows that HeapMonitorStatIntervalTest.java needed to make more iterations a well as other fixed tests.

[lmesnik]

/integrate

[openjdk]

Going to push as commit 09e5321.
Since your change was applied there have been 28 commits pushed to the master branch:

• 258f188: 8270961: [TESTBUG] Move GotWrongOOMEException into vm.share.gc package
• 3cadc36: 8270336: [TESTBUG] Fix initialization in NonbranchyTree
• c2ed336: 8270912: Clean up G1CollectedHeap::process_discovered_references()
• 8e27d4e: 8271043: Rename G1CollectedHeap::g1mm()
• d1257d5: 8271126: ProblemList runtime/InvocationTests/invokevirtualTests.java
• 50bb731: 8270286: com.sun.net.httpserver.spi.HttpServerProvider: remove use of deprecated API
• 9131a8f: 8267940: [macos] java/awt/print/Dialog/DialogOwnerTest.java fails
• 6096dd9: 8268893: jcmd to trim the glibc heap
• c36755d: Merge
• 89f7998: 8266347: assert(Dependencies::is_concrete_root_method(fm, ctxk) == Dependencies::is_concrete_method(m, ctxk)) failed: mismatch
• ... and 18 more: https://git.openjdk.java.net/jdk/compare/0790f04d8a41aa61b4633e822120d913ec89d900...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lmesnik Pushed as commit 09e5321.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.