Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8270870: Simplify G1ServiceThread #4868

Closed
wants to merge 6 commits into from

Conversation

@kimbarrett
Copy link

@kimbarrett kimbarrett commented Jul 22, 2021

Please review this simplification of the internal control structure of
G1ServiceThread, particularly around the entry and exit of monitor contexts.

In addition, the run_task logging now includes the delay between the
scheduled time to run and the actual, as that seems like useful information
to have sometimes.

I also changed the monitor rank from nonleaf to leaf. There was no reason
to use nonleaf, and leaf avoids questions about why nonleaf was used.

Testing:
mach5 tier1-3. This includes the gtest for G1ServiceThread.

Ran a test program with gc+task logging enabled and checked that the logging
output looked okay.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4868/head:pull/4868
$ git checkout pull/4868

Update a local copy of the PR:
$ git checkout pull/4868
$ git pull https://git.openjdk.java.net/jdk pull/4868/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4868

View PR using the GUI difftool:
$ git pr show -t 4868

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4868.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 22, 2021

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Jul 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 22, 2021

@kimbarrett The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the hotspot-gc label Jul 22, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 22, 2021

Webrevs

Loading

Copy link
Contributor

@tschatzl tschatzl left a comment

Lgtm.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 22, 2021

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270870: Simplify G1ServiceThread

Reviewed-by: tschatzl, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 8c8e3a0: 8271163: G1 uses wrong degree of MT processing since JDK-8270169
  • 8a789b7: 8263840: PeriodicTask should declare its destructor virtual

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jul 22, 2021
Copy link
Member

@walulyai walulyai left a comment

Lgtm!

Loading

@kimbarrett
Copy link
Author

@kimbarrett kimbarrett commented Jul 23, 2021

Thanks @tschatzl and @walulyai for reviews.

Loading

@kimbarrett
Copy link
Author

@kimbarrett kimbarrett commented Jul 23, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 23, 2021

Going to push as commit 0cc4bb7.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 8c8e3a0: 8271163: G1 uses wrong degree of MT processing since JDK-8270169
  • 8a789b7: 8263840: PeriodicTask should declare its destructor virtual

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Jul 23, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 23, 2021

@kimbarrett Pushed as commit 0cc4bb7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@kimbarrett kimbarrett deleted the g1service_thread branch Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants