-
Notifications
You must be signed in to change notification settings - Fork 6k
8270870: Simplify G1ServiceThread #4868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into |
@kimbarrett The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
@kimbarrett This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
/integrate |
Going to push as commit 0cc4bb7.
Your commit was automatically rebased without conflicts. |
@kimbarrett Pushed as commit 0cc4bb7. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review this simplification of the internal control structure of
G1ServiceThread, particularly around the entry and exit of monitor contexts.
In addition, the run_task logging now includes the delay between the
scheduled time to run and the actual, as that seems like useful information
to have sometimes.
I also changed the monitor rank from nonleaf to leaf. There was no reason
to use nonleaf, and leaf avoids questions about why nonleaf was used.
Testing:
mach5 tier1-3. This includes the gtest for G1ServiceThread.
Ran a test program with gc+task logging enabled and checked that the logging
output looked okay.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4868/head:pull/4868
$ git checkout pull/4868
Update a local copy of the PR:
$ git checkout pull/4868
$ git pull https://git.openjdk.java.net/jdk pull/4868/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4868
View PR using the GUI difftool:
$ git pr show -t 4868
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4868.diff