Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271126: ProblemList runtime/InvocationTests/invokevirtualTests.java #4869

Closed
wants to merge 2 commits into from

Conversation

jamsheedcm
Copy link
Member

@jamsheedcm jamsheedcm commented Jul 22, 2021

In order to reduce the noise in the JDK17/JDK18 CI,
I'm ProblemListing:
runtime/InvocationTests/invokevirtualTests.java


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8271126: ProblemList runtime/InvocationTests/invokevirtualTests.java

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4869/head:pull/4869
$ git checkout pull/4869

Update a local copy of the PR:
$ git checkout pull/4869
$ git pull https://git.openjdk.java.net/jdk pull/4869/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4869

View PR using the GUI difftool:
$ git pr show -t 4869

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4869.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 22, 2021

👋 Welcome back jcm! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 22, 2021

@jamsheedcm To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • 2d
  • awt
  • beans
  • build
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah
  • sound
  • swing

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 22, 2021
@jamsheedcm
Copy link
Member Author

jamsheedcm commented Jul 22, 2021

/label hotspot-compiler

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jul 22, 2021
@openjdk
Copy link

openjdk bot commented Jul 22, 2021

@jamsheedcm
The hotspot-compiler label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Jul 22, 2021

Webrevs

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial.

@jamsheedcm
Copy link
Member Author

Thanks for the review, Tobias
/integrate

@openjdk
Copy link

openjdk bot commented Jul 22, 2021

@jamsheedcm This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271126: ProblemList runtime/InvocationTests/invokevirtualTests.java

Reviewed-by: thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 50bb731: 8270286: com.sun.net.httpserver.spi.HttpServerProvider: remove use of deprecated API

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 22, 2021
@openjdk
Copy link

openjdk bot commented Jul 22, 2021

Going to push as commit d1257d5.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 50bb731: 8270286: com.sun.net.httpserver.spi.HttpServerProvider: remove use of deprecated API

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 22, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 22, 2021
@openjdk
Copy link

openjdk bot commented Jul 22, 2021

@jamsheedcm Pushed as commit d1257d5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants