Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8271142: package help is not displayed for missing X11/extensions/Xrandr.h #4873

Closed
wants to merge 2 commits into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Jul 22, 2021

Please review the following change.
On SUSE Linux 15 configure was running into this error, because of a missing X11 header :

checking for X11/extensions/Xrandr.h... no
configure: error: Could not find all X11 headers (shape.h Xrender.h Xrandr.h XTest.h Intrinsic.h).

I wondered about the missing package help output, we should display some hint what packages are missing.
In help.m4, PKGHANDLER was detected as /usr/bin/zypper .
However only the exact string zypper is checked, this should be relaxed.
Afterwards, the package - help was working nicely :

checking for X11/extensions/Xrandr.h... no
configure: error: Could not find all X11 headers (shape.h Xrender.h Xrandr.h XTest.h Intrinsic.h).
You might be able to fix this by running 'sudo zypper install libX11-devel libXext-devel libXrender-devel libXrandr-devel libXtst-devel libXt-devel libXi-devel'.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8271142: package help is not displayed for missing X11/extensions/Xrandr.h

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4873/head:pull/4873
$ git checkout pull/4873

Update a local copy of the PR:
$ git checkout pull/4873
$ git pull https://git.openjdk.java.net/jdk pull/4873/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4873

View PR using the GUI difftool:
$ git pr show -t 4873

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4873.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 22, 2021

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jul 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 22, 2021

@MBaesken The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build label Jul 22, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 22, 2021

Webrevs

Copy link
Contributor

@RealCLanger RealCLanger left a comment

Makes sense to me.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 23, 2021

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271142: package help is not displayed for missing X11/extensions/Xrandr.h

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 31 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 23, 2021
@MBaesken
Copy link
Member Author

@MBaesken MBaesken commented Jul 23, 2021

Makes sense to me.

Hi Christoph, thanks for looking into it. Should we do the same for the other package managers in the case statement (like yum, apt-get) as well ? I only observed it on SLES15 (where zypper was detected) but it might be also an issue on the others.
Btw should I better use *zypper because I think it will always the suffix of the string?

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Jul 23, 2021

Makes sense to me.

Hi Christoph, thanks for looking into it. Should we do the same for the other package managers in the case statement (like yum, apt-get) as well ? I only observed it on SLES15 (where zypper was detected) but it might be also an issue on the others.
Btw should I better use *zypper because I think it will always the suffix of the string?

Using just *zypper probably makes sense. For the other package managers it could also make sense to relax the check. I guess you should check it on relevant systems...

Copy link
Contributor

@RealCLanger RealCLanger left a comment

Looks good.

@MBaesken
Copy link
Member Author

@MBaesken MBaesken commented Jul 23, 2021

Hi Christoph, thanks for looking into it. Should we do the same for the other package managers in the case statement (like yum, apt-get) as well ? I only observed it on SLES15 (where zypper was detected) but it might be also an issue on the others.
Btw should I better use *zypper because I think it will always the suffix of the string?

Using just *zypper probably makes sense. For the other package managers it could also make sense to relax the check. I guess you should check it on relevant systems...

Checked on RHEL and we have the same issue there too.
before :

configure: error: Could not find cups!
configure exiting with result code 1

after adding my fix :

configure: error: Could not find cups! You might be able to fix this by running 'sudo yum install cups-devel'.
configure exiting with result code 1

So yes, the other distros/pkg handlers had the same issue.

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 20, 2021

@MBaesken This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@MBaesken
Copy link
Member Author

@MBaesken MBaesken commented Aug 23, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Aug 23, 2021

Going to push as commit b7f75c0.
Since your change was applied there have been 338 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 23, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 23, 2021

@MBaesken Pushed as commit b7f75c0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build integrated
2 participants