Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271165: ProblemList serviceability/dcmd/gc/HeapDumpAllTest.java on X64 #4881

Closed
wants to merge 2 commits into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Jul 22, 2021

Trivial fixes:
JDK-8271165 ProblemList serviceability/dcmd/gc/HeapDumpAllTest.java on X64
JDK-8271166 ProblemList applications/jcstress/copy.java on Linux-X64


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issues

  • JDK-8271165: ProblemList serviceability/dcmd/gc/HeapDumpAllTest.java on X64
  • JDK-8271166: ProblemList applications/jcstress/copy.java on Linux-X64

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4881/head:pull/4881
$ git checkout pull/4881

Update a local copy of the PR:
$ git checkout pull/4881
$ git pull https://git.openjdk.java.net/jdk pull/4881/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4881

View PR using the GUI difftool:
$ git pr show -t 4881

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4881.diff

@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime
/label add serviceability

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review July 22, 2021 21:51
@dcubed-ojdk dcubed-ojdk marked this pull request as draft July 22, 2021 21:54
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 22, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jul 22, 2021
@openjdk
Copy link

openjdk bot commented Jul 22, 2021

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Jul 22, 2021
@openjdk
Copy link

openjdk bot commented Jul 22, 2021

@dcubed-ojdk
The serviceability label was successfully added.

@openjdk openjdk bot changed the title 8271165: ProblemList serviceability/dcmd/gc/HeapDumpAllTest.java 8271165: ProblemList serviceability/dcmd/gc/HeapDumpAllTest.java on X64 Jul 22, 2021
@dcubed-ojdk
Copy link
Member Author

/issue add JDK-8271165

@dcubed-ojdk
Copy link
Member Author

/issue add JDK-8271166

@openjdk
Copy link

openjdk bot commented Jul 22, 2021

@dcubed-ojdk This issue is referenced in the PR title - it will now be updated.

@openjdk
Copy link

openjdk bot commented Jul 22, 2021

@dcubed-ojdk
Adding additional issue to issue list: 8271166: ProblemList applications/jcstress/copy.java on Linux-X64.

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review July 22, 2021 23:38
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 22, 2021
@mlbridge
Copy link

mlbridge bot commented Jul 22, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 22, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271165: ProblemList serviceability/dcmd/gc/HeapDumpAllTest.java on X64
8271166: ProblemList applications/jcstress/copy.java on Linux-X64

Reviewed-by: darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 22, 2021
@dcubed-ojdk
Copy link
Member Author

@jddarcy - Thanks for the fast review!

/integrate

@openjdk
Copy link

openjdk bot commented Jul 22, 2021

Going to push as commit a7d3012.

@openjdk openjdk bot closed this Jul 22, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 22, 2021
@openjdk
Copy link

openjdk bot commented Jul 22, 2021

@dcubed-ojdk Pushed as commit a7d3012.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8271165 branch July 23, 2021 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
2 participants