Skip to content

8271209: Fix doc comment typos in JavadocTokenizer #4889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

pavelrappo
Copy link
Member

@pavelrappo pavelrappo commented Jul 23, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8271209: Fix doc comment typos in JavadocTokenizer

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4889/head:pull/4889
$ git checkout pull/4889

Update a local copy of the PR:
$ git checkout pull/4889
$ git pull https://git.openjdk.java.net/jdk pull/4889/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4889

View PR using the GUI difftool:
$ git pr show -t 4889

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4889.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 23, 2021

👋 Welcome back prappo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 23, 2021

@pavelrappo The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler compiler-dev@openjdk.org label Jul 23, 2021
Copy link
Member

@JimLaskey JimLaskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Jul 23, 2021

@pavelrappo This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271209: Fix doc comment typos in JavadocTokenizer

Reviewed-by: jlaskey

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 23, 2021
@mlbridge
Copy link

mlbridge bot commented Jul 23, 2021

Webrevs

@pavelrappo
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 23, 2021

Going to push as commit c9251db.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 96247ae: 8270187: G1: Remove ConcGCThreads constraint

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 23, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 23, 2021
@openjdk
Copy link

openjdk bot commented Jul 23, 2021

@pavelrappo Pushed as commit c9251db.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants