8171382: java.time.Duration missing isPositive method

[naotoj]

Please review this PR to introduce java.time.Duration.isPositive() method. A CSR is also drafted.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8171382: java.time.Duration missing isPositive method

Reviewers

• Roger Riggs (@RogerRiggs - Reviewer)
• Joe Wang (@JoeWang-Java - Reviewer)
• Iris Clark (@irisclark - Reviewer)
• Brian Burkhalter (@bplb - Reviewer)
• Stephen Colebourne (@jodastephen - Author)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4892/head:pull/4892
$ git checkout pull/4892

Update a local copy of the PR:
$ git checkout pull/4892
$ git pull https://git.openjdk.java.net/jdk pull/4892/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4892

View PR using the GUI difftool:
$ git pr show -t 4892

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4892.diff

[bridgekeeper]

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[naotoj]

/csr

[openjdk]

@naotoj this pull request will not be integrated until the CSR request JDK-8271167 for issue JDK-8171382 has been approved.

[openjdk]

@naotoj The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (cd7d9137)

[RogerRiggs]

In the CSR, I would omit the "which is odd" from the "Problem".
and in the Solution, replace "integrity" with "completeness".

[naotoj]

Thanks, Roger. Modified the CSR as suggested.

[irisclark]

Looks good! I've also Reviewed the associated CSR.

[jodastephen]

I had to think whether this logic is correct, but I believe it is because nanos is 32 bits and positive so won't impact the negative bit of seconds.

[naotoj]

Thanks, Stephen. Yes, nanos is even smaller, less than 1,000,000,000.

[openjdk]

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8171382: java.time.Duration missing isPositive method

Reviewed-by: rriggs, joehw, iris, bpb, scolebourne

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 286106d: 8271219: [REDO] JDK-8271063 Print injected fields for InstanceKlass
• a1c0a6a: 8199594: Add doc describing how (?x) ignores spaces in character classes
• 4ed548b: 8268261: C2: assert(n != __null) failed: Bad immediate dominator info.

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[naotoj]

/integrate

[openjdk]

Going to push as commit efa63dc.
Since your change was applied there have been 14 commits pushed to the master branch:

• ee55361: 8265474: Dubious 'null' assignment in CompactByteArray.expand
• 515113d: 8269924: Shenandoah: Introduce weak/strong marking asserts
• f2c359a: 8271215: Fix data races in G1PeriodicGCTask
• 36aefa3: 8270447: [IR Framework] Add missing compilation level restriction when using FlipC1C2 stress option
• e4295cc: 8270519: Move several vector helper methods to shared header file
• e627cae: 8270317: Large Allocation in CipherSuite
• 0dcfc42: Merge
• 8adf008: 8269984: [macos] JTabbedPane title looks like disabled
• e90ed6c: 8271173: serviceability/jvmti/GetObjectSizeClass.java doesn't check exit code
• b4c6229: 8271189: runtime/handshake/HandshakeTimeoutTest.java can be run in driver mode
• ... and 4 more: https://git.openjdk.java.net/jdk/compare/ec71e2d891fdb9b102ce232f65cfcc5c6a1a9580...master

Your commit was automatically rebased without conflicts.

[openjdk]

@naotoj Pushed as commit efa63dc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.