8271219: [REDO] JDK-8271063 Print injected fields for InstanceKlass

[coleenp]

There was a test bug in the JDK-8271063. I thought I'd check the output of Method->print() except it's only available in debug mode. The basic diff is line 56 and 63 in the gtest. Retested with mach5 tier1 on 5 Oracle platforms.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8271219: [REDO] JDK-8271063 Print injected fields for InstanceKlass

Reviewers

• Daniel D. Daugherty (@dcubed-ojdk - Reviewer)
• Frederic Parain (@fparain - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4894/head:pull/4894
$ git checkout pull/4894

Update a local copy of the PR:
$ git checkout pull/4894
$ git pull https://git.openjdk.java.net/jdk pull/4894/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4894

View PR using the GUI difftool:
$ git pr show -t 4894

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4894.diff

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (05ff6d09)

[dcubed-ojdk]

Thumbs up! I also compared the original patch to the new patch.

It would be good to have one of the original reviewers chime in on this PR.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271219: [REDO] JDK-8271063 Print injected fields for InstanceKlass

Reviewed-by: dcubed, fparain

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• a1c0a6a: 8199594: Add doc describing how (?x) ignores spaces in character classes
• 4ed548b: 8268261: C2: assert(n != __null) failed: Bad immediate dominator info.

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[fparain]

LGTM

Fred

[coleenp]

Thanks Dan and Fred!
/integrate

[openjdk]

Going to push as commit 286106d.
Since your change was applied there have been 2 commits pushed to the master branch:

• a1c0a6a: 8199594: Add doc describing how (?x) ignores spaces in character classes
• 4ed548b: 8268261: C2: assert(n != __null) failed: Bad immediate dominator info.

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit 286106d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.