Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge jdk17 #4896

Closed
wants to merge 4 commits into from
Closed

Merge jdk17 #4896

wants to merge 4 commits into from

Conversation

@JesperIRL
Copy link
Member

@JesperIRL JesperIRL commented Jul 23, 2021

Forwardport JDK 17 -> JDK 18


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4896/head:pull/4896
$ git checkout pull/4896

Update a local copy of the PR:
$ git checkout pull/4896
$ git pull https://git.openjdk.java.net/jdk pull/4896/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4896

View PR using the GUI difftool:
$ git pr show -t 4896

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4896.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 23, 2021

👋 Welcome back jwilhelm! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 23, 2021

@JesperIRL This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Merge

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 23, 2021

@JesperIRL The following labels will be automatically applied to this pull request:

  • awt
  • hotspot-runtime
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@JesperIRL
Copy link
Member Author

@JesperIRL JesperIRL commented Jul 24, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 24, 2021

Going to push as commit 0dcfc42.

@openjdk openjdk bot closed this Jul 24, 2021
@openjdk openjdk bot added integrated and removed ready labels Jul 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 24, 2021

@JesperIRL Pushed as commit 0dcfc42.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr label Jul 24, 2021
@JesperIRL JesperIRL deleted the Merge_jdk17 branch Jul 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants