Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271215: Fix data races in G1PeriodicGCTask #4899

Closed
wants to merge 1 commit into from

Conversation

kimbarrett
Copy link

@kimbarrett kimbarrett commented Jul 24, 2021

Please review this small change to G1PeriodicGCTask, eliminating unlikely
but possible data races with a concurrently running GC pause. An STS-joiner
is used to ensure there isn't a GC pause while doing the checks to decide
whether to perform a periodic GC.

Testing:
mach5 tier1


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4899/head:pull/4899
$ git checkout pull/4899

Update a local copy of the PR:
$ git checkout pull/4899
$ git pull https://git.openjdk.java.net/jdk pull/4899/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4899

View PR using the GUI difftool:
$ git pr show -t 4899

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4899.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 24, 2021

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jul 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 24, 2021

@kimbarrett The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Jul 24, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 24, 2021

Webrevs

Copy link
Contributor

@shipilev shipilev left a comment

Looks fine.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 26, 2021

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271215: Fix data races in G1PeriodicGCTask

Reviewed-by: iwalulya, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • e4295cc: 8270519: Move several vector helper methods to shared header file
  • e627cae: 8270317: Large Allocation in CipherSuite

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 26, 2021
@kimbarrett
Copy link
Author

@kimbarrett kimbarrett commented Jul 26, 2021

Thanks @walulyai and @shipilev for reviews.

@kimbarrett
Copy link
Author

@kimbarrett kimbarrett commented Jul 26, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 26, 2021

Going to push as commit f2c359a.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 36aefa3: 8270447: [IR Framework] Add missing compilation level restriction when using FlipC1C2 stress option
  • e4295cc: 8270519: Move several vector helper methods to shared header file
  • e627cae: 8270317: Large Allocation in CipherSuite

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 26, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 26, 2021

@kimbarrett Pushed as commit f2c359a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kimbarrett kimbarrett deleted the g1periodic_sts branch Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated
3 participants