8253948: Memory leak in ImageFileReader #490
ImageFileReader allocates ImageModuleData in ImageFileReader::open(), but never free.
Also renamed module_data to _module_data to be consistent with other member variables.
@zhengyu123 To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.
AlanBateman left a comment
The jimage file is opened at startup and should never be closed. However the jrtfs provider (used by IDEs and other tools to access the resources in a target run-time image) may run into it so good to get it fixed.
Can you fix the formatting to use 4-space indentation consistently?
@zhengyu123 This change now passes all automated pre-integration checks.
After integration, the commit message for the final commit will be:
At the time when this comment was updated there had been 54 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
@zhengyu123 Since your change was applied there have been 56 commits pushed to the
Your commit was automatically rebased without conflicts.
Pushed as commit 81dae70.