New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8266510: Nimbus JTree default tree cell renderer does not use selected text color #4903
Conversation
👋 Welcome back trebari! A progress list of the required criteria for merging this PR into |
@trebari This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Do we have a new bug to redo the https://bugs.openjdk.java.net/browse/JDK-8249674 again? |
|
Thank you, looks fine. |
/integrate |
Going to push as commit ecd4455.
Your commit was automatically rebased without conflicts. |
Please review the following fix for JDK-18.
This is revert of the fix for nimbus jtree renderer properties persist across L&F(https://bugs.openjdk.java.net/browse/JDK-8249674), This fixed caused nimbus jtree default tree cell renderer to not use the selected text color, which was white originally and changed to black after the fix. Reverted the change to match original behaviour.
Tested on MacOS , Windows and Linux.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4903/head:pull/4903
$ git checkout pull/4903
Update a local copy of the PR:
$ git checkout pull/4903
$ git pull https://git.openjdk.java.net/jdk pull/4903/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4903
View PR using the GUI difftool:
$ git pr show -t 4903
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4903.diff