Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266510: Nimbus JTree default tree cell renderer does not use selected text color #4903

Closed
wants to merge 1 commit into from

Conversation

trebari
Copy link
Member

@trebari trebari commented Jul 26, 2021

Please review the following fix for JDK-18.
This is revert of the fix for nimbus jtree renderer properties persist across L&F(https://bugs.openjdk.java.net/browse/JDK-8249674), This fixed caused nimbus jtree default tree cell renderer to not use the selected text color, which was white originally and changed to black after the fix. Reverted the change to match original behaviour.

Tested on MacOS , Windows and Linux.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8266510: Nimbus JTree default tree cell renderer does not use selected text color

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4903/head:pull/4903
$ git checkout pull/4903

Update a local copy of the PR:
$ git checkout pull/4903
$ git pull https://git.openjdk.java.net/jdk pull/4903/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4903

View PR using the GUI difftool:
$ git pr show -t 4903

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4903.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 26, 2021

👋 Welcome back trebari! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 26, 2021
@openjdk
Copy link

openjdk bot commented Jul 26, 2021

@trebari The following label will be automatically applied to this pull request:

  • swing

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the swing client-libs-dev@openjdk.org label Jul 26, 2021
@mlbridge
Copy link

mlbridge bot commented Jul 26, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 26, 2021

@trebari This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266510: Nimbus JTree default tree cell renderer does not use selected text color

Reviewed-by: psadhukhan, pbansal

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • e4295cc: 8270519: Move several vector helper methods to shared header file

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 26, 2021
@mrserb
Copy link
Member

mrserb commented Jul 26, 2021

Do we have a new bug to redo the https://bugs.openjdk.java.net/browse/JDK-8249674 again?

@trebari
Copy link
Member Author

trebari commented Jul 27, 2021

@mrserb
Copy link
Member

mrserb commented Jul 28, 2021

Yes, https://bugs.openjdk.java.net/browse/JDK-8271315.

Thank you, looks fine.

@trebari
Copy link
Member Author

trebari commented Jul 28, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Jul 28, 2021

Going to push as commit ecd4455.
Since your change was applied there have been 33 commits pushed to the master branch:

  • d994b93: 8266054: VectorAPI rotate operation optimization
  • ed1cb24: 8271118: C2: StressGCM should have higher priority than frequency-based policy
  • 9bc52af: 8271323: [TESTBUG] serviceability/sa/ClhsdbCDSCore.java fails with -XX:TieredStopAtLevel=1
  • 752b6df: 8261236: C2: ClhsdbJstackXcompStress test fails when StressGCM is enabled
  • a50161b: Merge
  • f1e15c8: 8271350: runtime/Safepoint tests use OutputAnalyzer::shouldMatch instead of shouldContaint
  • fbe28e4: 8270866: NPE in DocTreePath.getTreePath()
  • f662127: 8270491: SEGV at read_string_field(oopDesc*, char const*, JavaThread*)+0x54
  • cea7bc2: 8271223: two runtime/ClassFile tests don't check exit code
  • 90cd2fa: 8270859: Post JEP 411 refactoring: client libs with maximum covering > 10K
  • ... and 23 more: https://git.openjdk.java.net/jdk/compare/e627caec84c169c99c04e0d355c29b806a0266ed...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 28, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 28, 2021
@openjdk
Copy link

openjdk bot commented Jul 28, 2021

@trebari Pushed as commit ecd4455.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated swing client-libs-dev@openjdk.org
4 participants