Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8270925: replay dump using CICrashAt does not include inlining data #4908

Closed
wants to merge 4 commits into from

Conversation

dean-long
Copy link
Member

@dean-long dean-long commented Jul 27, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8270925: replay dump using CICrashAt does not include inlining data

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4908/head:pull/4908
$ git checkout pull/4908

Update a local copy of the PR:
$ git checkout pull/4908
$ git pull https://git.openjdk.java.net/jdk pull/4908/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4908

View PR using the GUI difftool:
$ git pr show -t 4908

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4908.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 27, 2021

👋 Welcome back dlong! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8270925: replay dump using CICrashAt does not include inlining data 8270925: replay dump using CICrashAt does not include inlining data Jul 27, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 27, 2021

@dean-long The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-compiler rfr labels Jul 27, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 27, 2021

Webrevs

@dean-long
Copy link
Member Author

@dean-long dean-long commented Jul 27, 2021

/test

@openjdk
Copy link

@openjdk openjdk bot commented Jul 27, 2021

Could not create test job

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Good.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 27, 2021

@dean-long This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270925: replay dump using CICrashAt does not include inlining data

Reviewed-by: kvn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

  • 072fe48: 8270901: Typo PHASE_CPP in CompilerPhaseType
  • d7b5cb6: 8271368: [BACKOUT] JDK-8266054 VectorAPI rotate operation optimization
  • ecd4455: 8266510: Nimbus JTree default tree cell renderer does not use selected text color
  • d994b93: 8266054: VectorAPI rotate operation optimization
  • ed1cb24: 8271118: C2: StressGCM should have higher priority than frequency-based policy
  • 9bc52af: 8271323: [TESTBUG] serviceability/sa/ClhsdbCDSCore.java fails with -XX:TieredStopAtLevel=1
  • 752b6df: 8261236: C2: ClhsdbJstackXcompStress test fails when StressGCM is enabled
  • a50161b: Merge
  • f1e15c8: 8271350: runtime/Safepoint tests use OutputAnalyzer::shouldMatch instead of shouldContaint
  • fbe28e4: 8270866: NPE in DocTreePath.getTreePath()
  • ... and 15 more: https://git.openjdk.java.net/jdk/compare/fcc7d59b9937a34c423e4532058668144b0ec1fb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 27, 2021
@dean-long
Copy link
Member Author

@dean-long dean-long commented Jul 27, 2021

Thanks Vladimir.

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Looks good to me otherwise.

@@ -0,0 +1,78 @@
/*
* Copyright (c) 2016, 2021, Oracle and/or its affiliates. All rights reserved.
Copy link
Member

@TobiHartmann TobiHartmann Jul 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the copyright date should just be 2021, right?

Copy link
Member Author

@dean-long dean-long Jul 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied TestVMNoCompLevel.java and then modified it, so I think keeping the start year is correct, as long as that content was non-trivial. But I can change it if you feel strongly about it.

Copy link
Member

@TobiHartmann TobiHartmann Jul 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, makes sense then to keep it as is.

@dean-long
Copy link
Member Author

@dean-long dean-long commented Jul 28, 2021

Thanks Tobias.

@dean-long
Copy link
Member Author

@dean-long dean-long commented Jul 28, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 28, 2021

Going to push as commit 034788a.
Since your change was applied there have been 29 commits pushed to the master branch:

  • 9711033: 8209776: Refactor jdk/security/JavaDotSecurity/ifdefs.sh to plain java test
  • 60c11fe: 8261088: Repeatable annotations without @target cannot have containers that target module declarations
  • dcdb1b6: 8137101: [TEST_BUG] javax/swing/plaf/basic/BasicHTML/4251579/bug4251579.java failure due to timing
  • a066c7b: 8270086: ARM32-softfp: Do not load CONSTANT_double using the condy helper methods in the interpreter
  • 072fe48: 8270901: Typo PHASE_CPP in CompilerPhaseType
  • d7b5cb6: 8271368: [BACKOUT] JDK-8266054 VectorAPI rotate operation optimization
  • ecd4455: 8266510: Nimbus JTree default tree cell renderer does not use selected text color
  • d994b93: 8266054: VectorAPI rotate operation optimization
  • ed1cb24: 8271118: C2: StressGCM should have higher priority than frequency-based policy
  • 9bc52af: 8271323: [TESTBUG] serviceability/sa/ClhsdbCDSCore.java fails with -XX:TieredStopAtLevel=1
  • ... and 19 more: https://git.openjdk.java.net/jdk/compare/fcc7d59b9937a34c423e4532058668144b0ec1fb...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 28, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 28, 2021

@dean-long Pushed as commit 034788a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dean-long dean-long deleted the 8270925 branch Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler integrated
3 participants