New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8271242: Add Arena regression tests #4909
8271242: Add Arena regression tests #4909
Conversation
|
Thank you for adding these tests. These new tests look good to me (from HotSpot test engineer POV). Someone who is an expert in Arena allocation should review this change as well.
* @library /test/lib | ||
* @modules java.base/jdk.internal.misc | ||
* java.xml | ||
* @requires vm.flagless |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style comment: Please group all at-requires together in the same or neighboring lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do.
Thank you Mikhailo! |
ASSERT_FALSE(ar.contains(p)); | ||
} | ||
// Allocate again. The new allocations should have the same position as the 0-sized | ||
// first one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems so dangerous to allow zero sized Amalloc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, but I wanted these tests to test existing behavior.
I tried to do a quick "lets assert > 0" and that backfired, a bit of cleanup would be needed at the caller side.
@tstuefe This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 36 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
Thank you Coleen! |
/integrate |
Going to push as commit cd7e30e.
Your commit was automatically rebased without conflicts. |
May I please have reviews for these test additions. These are new regression tests for hotspot arenas. We don't have any and it makes sense to have them since this code is fragile and we work on it.
It also contains some new gtest utility functions which I will use to consolidate some more test coding, mainly in the metaspace gtests (in a future rfe).
It also comes with a new jtreg gtest launcher for arena tests to test UseMallocOnly mode. As long as we support that, we should test it.
tests:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4909/head:pull/4909
$ git checkout pull/4909
Update a local copy of the PR:
$ git checkout pull/4909
$ git pull https://git.openjdk.java.net/jdk pull/4909/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4909
View PR using the GUI difftool:
$ git pr show -t 4909
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4909.diff