Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271323: [TESTBUG] serviceability/sa/ClhsdbCDSCore.java fails with -XX:TieredStopAtLevel=1 #4910

Closed
wants to merge 1 commit into from

Conversation

nick-arm
Copy link
Member

@nick-arm nick-arm commented Jul 27, 2021

This test fails reliably with -XX:TieredStopAtLevel=1 since JDK-8251462. MDOs are no longer allocated in this mode so the clhsdb printmdo -a command prints nothing. The failure is basically the same as JDK-8236042 which happened with -Xcomp -XX:TieredStopAtLevel=1 so the workaround for that just needs to be adjusted slightly.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8271323: [TESTBUG] serviceability/sa/ClhsdbCDSCore.java fails with -XX:TieredStopAtLevel=1

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4910/head:pull/4910
$ git checkout pull/4910

Update a local copy of the PR:
$ git checkout pull/4910
$ git pull https://git.openjdk.java.net/jdk pull/4910/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4910

View PR using the GUI difftool:
$ git pr show -t 4910

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4910.diff

…X:TieredStopAtLevel=1

This test fails reliably with -XX:TieredStopAtLevel=1 since JDK-8251462.
MDOs are no longer allocated in this mode so the clhsdb printmdo -a
command prints nothing.  The failure is basically the same as
JDK-8236042 which happened with -Xcomp -XX:TieredStopAtLevel=1, so the
workaround for that just needs to be adjusted slightly.
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 27, 2021

👋 Welcome back ngasson! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jul 27, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 27, 2021

@nick-arm The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability label Jul 27, 2021
@nick-arm
Copy link
Member Author

@nick-arm nick-arm commented Jul 27, 2021

/label add hotspot-compiler

@openjdk openjdk bot added the hotspot-compiler label Jul 27, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 27, 2021

@nick-arm
The hotspot-compiler label was successfully added.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 27, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Jul 27, 2021

@nick-arm This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271323: [TESTBUG] serviceability/sa/ClhsdbCDSCore.java fails with -XX:TieredStopAtLevel=1

Reviewed-by: cjplummer, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 90cd2fa: 8270859: Post JEP 411 refactoring: client libs with maximum covering > 10K
  • c8af823: 8267485: Remove the dependency on SecurityManager in JceSecurityManager.java
  • ea49691: 8270794: Avoid loading Klass* twice in TypeArrayKlass::oop_size()
  • fc80a6b: 8270946: X509CertImpl.getFingerprint should not return the empty String

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 27, 2021
Copy link
Contributor

@vnkozlov vnkozlov left a comment

Good and trivial.

@nick-arm
Copy link
Member Author

@nick-arm nick-arm commented Jul 28, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 28, 2021

Going to push as commit 9bc52af.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 752b6df: 8261236: C2: ClhsdbJstackXcompStress test fails when StressGCM is enabled
  • a50161b: Merge
  • f1e15c8: 8271350: runtime/Safepoint tests use OutputAnalyzer::shouldMatch instead of shouldContaint
  • fbe28e4: 8270866: NPE in DocTreePath.getTreePath()
  • f662127: 8270491: SEGV at read_string_field(oopDesc*, char const*, JavaThread*)+0x54
  • cea7bc2: 8271223: two runtime/ClassFile tests don't check exit code
  • 90cd2fa: 8270859: Post JEP 411 refactoring: client libs with maximum covering > 10K
  • c8af823: 8267485: Remove the dependency on SecurityManager in JceSecurityManager.java
  • ea49691: 8270794: Avoid loading Klass* twice in TypeArrayKlass::oop_size()
  • fc80a6b: 8270946: X509CertImpl.getFingerprint should not return the empty String

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 28, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 28, 2021

@nick-arm Pushed as commit 9bc52af.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler integrated serviceability
3 participants