8270061: Change parameter order of ResourceHashtable

[iklam]

The template parameter for ResourceHashtable is currently in this order:

template<
    typename K, typename V,
    unsigned (*HASH)  (K const&)           = primitive_hash<K>,
    bool     (*EQUALS)(K const&, K const&) = primitive_equals<K>,
    unsigned SIZE = 256,
    ResourceObj::allocation_type ALLOC_TYPE = ResourceObj::RESOURCE_AREA,
    MEMFLAGS MEM_TYPE = mtInternal
    >
class ResourceHashtable {...}

However, more often than not, default values of HASH and EQUALS will be used, where the other parameters may need to be specified.

We should move the HASH and EQUALS parameters to the end of the parameter list.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8270061: Change parameter order of ResourceHashtable

Reviewers

• Coleen Phillimore (@coleenp - Reviewer) ⚠️ Review applies to dd6afc8
• Thomas Stuefe (@tstuefe - Reviewer) ⚠️ Review applies to dd6afc8

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4912/head:pull/4912
$ git checkout pull/4912

Update a local copy of the PR:
$ git checkout pull/4912
$ git pull https://git.openjdk.java.net/jdk pull/4912/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4912

View PR using the GUI difftool:
$ git pr show -t 4912

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4912.diff

[bridgekeeper]

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iklam The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (56abd91e)
• 01: Full - Incremental (3a87c5db)
• 00: Full (dd6afc8f)

[coleenp]

Looks good. Thanks for doing this!

[openjdk]

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270061: Change parameter order of ResourceHashtable

Reviewed-by: coleenp, stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tstuefe]

Looks good.

One could save even more writing by some more reordering: move MEMFLAGS upfront, since its is usually specified, and make the default allocator C_HEAP, because more users seem to want a C-heap map than a resource area one.

But this is just idle nitpicking, the change is good as it is.

..Thomas

[coleenp]

Oh but MEMFLAGS is generally found after the allocation type and I thought there were more resource allocated resource hashtables (at least initially).

[iklam]

Oh but MEMFLAGS is generally found after the allocation type and I thought there were more resource allocated resource hashtables (at least initially).

OK, I'll leave the PR as is without further rearranging the arguments.

Since the class is named ResourceHashtable, using C_HEAP as the default seems a little weird. We are planning to get rid of the "old" Hashtable and then rename ResourceHashtable to Hashtable. We can rethink the default values at that point.

[tstuefe]

Oh but MEMFLAGS is generally found after the allocation type and I thought there were more resource allocated resource hashtables (at least initially).

OK, I'll leave the PR as is without further rearranging the arguments.

Since the class is named ResourceHashtable, using C_HEAP as the default seems a little weird. We are planning to get rid of the "old" Hashtable and then rename ResourceHashtable to Hashtable. We can rethink the default values at that point.

Sure, all good!

[iklam]

Thanks @coleenp and @tstuefe for the review.
/integrate

[openjdk]

Going to push as commit 357947a.
Since your change was applied there have been 3 commits pushed to the master branch:

• 034788a: 8270925: replay dump using CICrashAt does not include inlining data
• 9711033: 8209776: Refactor jdk/security/JavaDotSecurity/ifdefs.sh to plain java test
• 60c11fe: 8261088: Repeatable annotations without @target cannot have containers that target module declarations

Your commit was automatically rebased without conflicts.

[openjdk]

@iklam Pushed as commit 357947a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.