Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271368: [BACKOUT] JDK-8266054 VectorAPI rotate operation optimization #4915

Closed
wants to merge 1 commit into from

Conversation

@vnkozlov
Copy link
Contributor

@vnkozlov vnkozlov commented Jul 28, 2021

Backout the following changes due to vector tests failures in tier 2 and later:
JDK-8266054 VectorAPI rotate operation optimization

Changes also caused copyright header validation failure in Tier1 due to missing , after copyright year in new test.

Currently running testing.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8271368: [BACKOUT] JDK-8266054 VectorAPI rotate operation optimization

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4915/head:pull/4915
$ git checkout pull/4915

Update a local copy of the PR:
$ git checkout pull/4915
$ git pull https://git.openjdk.java.net/jdk pull/4915/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4915

View PR using the GUI difftool:
$ git pr show -t 4915

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4915.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 28, 2021

👋 Welcome back kvn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jul 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 28, 2021

@vnkozlov The following labels will be automatically applied to this pull request:

  • core-libs
  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Backout looks good.

Thanks,
David

@openjdk
Copy link

@openjdk openjdk bot commented Jul 28, 2021

@vnkozlov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271368: [BACKOUT] JDK-8266054 VectorAPI rotate operation optimization

Reviewed-by: dholmes, iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 28, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 28, 2021

Webrevs

iklam
iklam approved these changes Jul 28, 2021
Copy link
Member

@iklam iklam left a comment

LGTM

@jatin-bhateja
Copy link
Member

@jatin-bhateja jatin-bhateja commented Jul 28, 2021

  • Thanks for reporting it, should it be ok to move those tests to ProblemList.txt and let me fix this as a follow up issue instead of a revert ?

@vnkozlov
Copy link
Contributor Author

@vnkozlov vnkozlov commented Jul 28, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 28, 2021

Going to push as commit d7b5cb6.

@openjdk openjdk bot closed this Jul 28, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 28, 2021

@vnkozlov Pushed as commit d7b5cb6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@vnkozlov
Copy link
Contributor Author

@vnkozlov vnkozlov commented Jul 28, 2021

  • Thanks for reporting it, should it be ok to move those tests to ProblemList.txt and let me fix this as a follow up issue instead of a revert ?

@jatin-bhateja We did not test original changes in our testing infra. There could be other issues in high tiers which we don't know.
I prefer that you use 8271366 to prepare changes with fixed reported failure, file PR and let me run testing.

@vnkozlov vnkozlov deleted the JDK-8271368 branch Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants