Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8270901: Typo PHASE_CPP in CompilerPhaseType #4917

Closed
wants to merge 2 commits into from

Conversation

kelthuzadx
Copy link
Member

@kelthuzadx kelthuzadx commented Jul 28, 2021

Should be PHASE_CCP instead of PHASE_CPP, it also affects dumped ideal graph XML.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4917/head:pull/4917
$ git checkout pull/4917

Update a local copy of the PR:
$ git checkout pull/4917
$ git pull https://git.openjdk.java.net/jdk pull/4917/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4917

View PR using the GUI difftool:
$ git pr show -t 4917

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4917.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 28, 2021

👋 Welcome back yyang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jul 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 28, 2021

@kelthuzadx The following labels will be automatically applied to this pull request:

  • hotspot-compiler
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability hotspot-compiler labels Jul 28, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 28, 2021

Webrevs

Copy link
Member

@DamonFool DamonFool left a comment

Looks good to me.

The copyright year should also be updated.
Thanks.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 28, 2021

@kelthuzadx This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270901: Typo PHASE_CPP in CompilerPhaseType

Reviewed-by: jiefu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 112 new commits pushed to the master branch:

  • d7b5cb6: 8271368: [BACKOUT] JDK-8266054 VectorAPI rotate operation optimization
  • ecd4455: 8266510: Nimbus JTree default tree cell renderer does not use selected text color
  • d994b93: 8266054: VectorAPI rotate operation optimization
  • ed1cb24: 8271118: C2: StressGCM should have higher priority than frequency-based policy
  • 9bc52af: 8271323: [TESTBUG] serviceability/sa/ClhsdbCDSCore.java fails with -XX:TieredStopAtLevel=1
  • 752b6df: 8261236: C2: ClhsdbJstackXcompStress test fails when StressGCM is enabled
  • a50161b: Merge
  • f1e15c8: 8271350: runtime/Safepoint tests use OutputAnalyzer::shouldMatch instead of shouldContaint
  • fbe28e4: 8270866: NPE in DocTreePath.getTreePath()
  • f662127: 8270491: SEGV at read_string_field(oopDesc*, char const*, JavaThread*)+0x54
  • ... and 102 more: https://git.openjdk.java.net/jdk/compare/1eeb1791abc438a65fa3491d1cd14ad69ef1ff98...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 28, 2021
@kelthuzadx
Copy link
Member Author

@kelthuzadx kelthuzadx commented Jul 28, 2021

Thank you Jie for review!

@kelthuzadx
Copy link
Member Author

@kelthuzadx kelthuzadx commented Jul 28, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 28, 2021

Going to push as commit 072fe48.
Since your change was applied there have been 112 commits pushed to the master branch:

  • d7b5cb6: 8271368: [BACKOUT] JDK-8266054 VectorAPI rotate operation optimization
  • ecd4455: 8266510: Nimbus JTree default tree cell renderer does not use selected text color
  • d994b93: 8266054: VectorAPI rotate operation optimization
  • ed1cb24: 8271118: C2: StressGCM should have higher priority than frequency-based policy
  • 9bc52af: 8271323: [TESTBUG] serviceability/sa/ClhsdbCDSCore.java fails with -XX:TieredStopAtLevel=1
  • 752b6df: 8261236: C2: ClhsdbJstackXcompStress test fails when StressGCM is enabled
  • a50161b: Merge
  • f1e15c8: 8271350: runtime/Safepoint tests use OutputAnalyzer::shouldMatch instead of shouldContaint
  • fbe28e4: 8270866: NPE in DocTreePath.getTreePath()
  • f662127: 8270491: SEGV at read_string_field(oopDesc*, char const*, JavaThread*)+0x54
  • ... and 102 more: https://git.openjdk.java.net/jdk/compare/1eeb1791abc438a65fa3491d1cd14ad69ef1ff98...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 28, 2021
@openjdk openjdk bot added integrated and removed ready labels Jul 28, 2021
@kelthuzadx kelthuzadx deleted the JDK-8270901 branch Jul 28, 2021
@openjdk openjdk bot removed the rfr label Jul 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 28, 2021

@kelthuzadx Pushed as commit 072fe48.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@DamonFool
Copy link
Member

@DamonFool DamonFool commented Jul 28, 2021

For hotspot changes, it would be better to have a second review & wait for 24 hours before integration.
Thanks.

@kelthuzadx
Copy link
Member Author

@kelthuzadx kelthuzadx commented Jul 28, 2021

For hotspot changes, it would be better to have a second review & wait for 24 hours before integration.
Thanks.

Well, it seems a trivial change, maybe one review is okay. For non-trivial changes, we really need more reviews and wait for 24h before merging.

@dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Jul 28, 2021

@kelthuzadx - HotSpot changes require two reviews and a 24 hour waiting period.
You may propose in your review request that a change is "trivial" and if your
(R)eviewer agrees, then you may integrate with a single (R)eviewer and you don't
have to wait for 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler integrated serviceability
3 participants