Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8270947: AArch64: C1: use zero_words to initialize all objects #4919

Closed
wants to merge 16 commits into from

Conversation

theRealAph
Copy link
Contributor

@theRealAph theRealAph commented Jul 28, 2021

C1 has its own code generators for zeroing words. We should use the same logic for C1 and C2, which should give us better C1 performance and result in less code to maintain.

This is one of those patches that's a great joy to write, because it consists mainly of deletions. The code I've added is mostly adapters to allow the C1 code to use the memory-zeroing logic written originally for C2. This means we have less code, but also that VM configuration options (e.g. BlockZeroingLowLimit) work with C1 and C2 in th esame way.

Measuring the performance of memory allocation is quite tricky, so I've written a JMH test case that measures the raw allocation rate of the JVM for various object sizes. This is inevitably rather noisy because it combines the effects of both the allocation code and other GC-related pauses. Nonetheless, it's a useful sanity check.

The performance differences between old and one are mostly in the noise, but with large allocations the advantage of DC ZVA becomes apparent:

old:

RawAllocationRate.arrayTest_C1       8192  thrpt    5  11220.314 ± 336.878  ops/s
RawAllocationRate.arrayTest_C1      16384  thrpt    5  16655.815 ±  88.577  ops/s
RawAllocationRate.arrayTest_C1      65536  thrpt    5  28302.661 ± 155.513  ops/s
RawAllocationRate.arrayTest_C1     131072  thrpt    5  31434.868 ± 211.768  ops/s

new:

RawAllocationRate.arrayTest_C1       8192  thrpt    5  13677.987 ± 143.048  ops/s
RawAllocationRate.arrayTest_C1      16384  thrpt    5  19517.416 ± 155.004  ops/s
RawAllocationRate.arrayTest_C1      65536  thrpt    5  37348.536 ± 307.582  ops/s
RawAllocationRate.arrayTest_C1     131072  thrpt    5  43414.399 ±  58.317  ops/s

Full test results, Graviton 2 (i.e. Neoverse N1). Units are megabytes per second,
objects sizes are in bytes:

old:

Benchmark                          (size)   Mode  Cnt      Score     Error  Units
RawAllocationRate.arrayTest            32  thrpt    5   5092.798 ±  20.879  ops/s
RawAllocationRate.arrayTest            64  thrpt    5   9821.608 ±   6.250  ops/s
RawAllocationRate.arrayTest           256  thrpt    5  14117.192 ±  72.720  ops/s
RawAllocationRate.arrayTest          1024  thrpt    5   9090.514 ±  40.239  ops/s
RawAllocationRate.arrayTest          2048  thrpt    5   9842.503 ±  52.744  ops/s
RawAllocationRate.arrayTest          4096  thrpt    5   9866.179 ±   6.332  ops/s
RawAllocationRate.arrayTest          8192  thrpt    5  12836.968 ±  14.143  ops/s
RawAllocationRate.arrayTest         16384  thrpt    5  18970.307 ±  96.903  ops/s
RawAllocationRate.arrayTest         65536  thrpt    5  36709.095 ±  38.256  ops/s
RawAllocationRate.arrayTest        131072  thrpt    5  43055.263 ±  60.808  ops/s
RawAllocationRate.arrayTest_C1         32  thrpt    5   3045.285 ±  23.128  ops/s
RawAllocationRate.arrayTest_C1         64  thrpt    5   5774.157 ±  52.472  ops/s
RawAllocationRate.arrayTest_C1        256  thrpt    5   4720.713 ±   9.419  ops/s
RawAllocationRate.arrayTest_C1       1024  thrpt    5   7457.880 ± 806.208  ops/s
RawAllocationRate.arrayTest_C1       2048  thrpt    5   8155.046 ± 194.153  ops/s
RawAllocationRate.arrayTest_C1       4096  thrpt    5   8364.379 ± 127.661  ops/s
RawAllocationRate.arrayTest_C1       8192  thrpt    5  11220.314 ± 336.878  ops/s
RawAllocationRate.arrayTest_C1      16384  thrpt    5  16655.815 ±  88.577  ops/s
RawAllocationRate.arrayTest_C1      65536  thrpt    5  28302.661 ± 155.513  ops/s
RawAllocationRate.arrayTest_C1     131072  thrpt    5  31434.868 ± 211.768  ops/s
RawAllocationRate.instanceTest         32  thrpt    5   6667.433 ±  50.031  ops/s
RawAllocationRate.instanceTest         64  thrpt    5  10669.876 ±  72.109  ops/s
RawAllocationRate.instanceTest        256  thrpt    5   5483.582 ± 336.743  ops/s
RawAllocationRate.instanceTest       1024  thrpt    5   9740.872 ±   6.269  ops/s
RawAllocationRate.instanceTest       2048  thrpt    5   9868.685 ±  51.939  ops/s
RawAllocationRate.instanceTest       4096  thrpt    5   9881.944 ±  46.306  ops/s
RawAllocationRate.instanceTest       8192  thrpt    5  13524.791 ±  69.250  ops/s
RawAllocationRate.instanceTest      16384  thrpt    5  19560.774 ± 109.518  ops/s
RawAllocationRate.instanceTest      65536  thrpt    5  37510.256 ±  15.586  ops/s
RawAllocationRate.instanceTest     131072  thrpt    5  43361.887 ± 181.294  ops/s
RawAllocationRate.instanceTest_C1      32  thrpt    5   2851.135 ±  22.891  ops/s
RawAllocationRate.instanceTest_C1      64  thrpt    5   5476.183 ±  84.376  ops/s
RawAllocationRate.instanceTest_C1     256  thrpt    5   5105.347 ±  35.389  ops/s
RawAllocationRate.instanceTest_C1    1024  thrpt    5   7380.805 ±   3.944  ops/s
RawAllocationRate.instanceTest_C1    2048  thrpt    5   8963.428 ±  83.857  ops/s
RawAllocationRate.instanceTest_C1    4096  thrpt    5   9257.715 ±  52.647  ops/s
RawAllocationRate.instanceTest_C1    8192  thrpt    5  11655.359 ±  70.209  ops/s
RawAllocationRate.instanceTest_C1   16384  thrpt    5  17084.813 ±  91.150  ops/s
RawAllocationRate.instanceTest_C1   65536  thrpt    5  28682.783 ± 176.563  ops/s
RawAllocationRate.instanceTest_C1  131072  thrpt    5  31268.318 ± 221.486  ops/s

new:

Benchmark                          (size)   Mode  Cnt      Score     Error  Units
RawAllocationRate.arrayTest            32  thrpt    5   5355.477 ±  43.045  ops/s
RawAllocationRate.arrayTest            64  thrpt    5   9825.067 ±  55.493  ops/s
RawAllocationRate.arrayTest           256  thrpt    5  13984.865 ± 125.125  ops/s
RawAllocationRate.arrayTest          1024  thrpt    5   9025.380 ±  48.921  ops/s
RawAllocationRate.arrayTest          2048  thrpt    5   9844.463 ±   6.780  ops/s
RawAllocationRate.arrayTest          4096  thrpt    5   9866.566 ±  48.659  ops/s
RawAllocationRate.arrayTest          8192  thrpt    5  12753.622 ±  67.211  ops/s
RawAllocationRate.arrayTest         16384  thrpt    5  18890.419 ±  14.152  ops/s
RawAllocationRate.arrayTest         65536  thrpt    5  37322.124 ± 269.352  ops/s
RawAllocationRate.arrayTest        131072  thrpt    5  43017.952 ± 204.057  ops/s
RawAllocationRate.arrayTest_C1         32  thrpt    5   3102.221 ±  13.811  ops/s
RawAllocationRate.arrayTest_C1         64  thrpt    5   5947.419 ±  36.408  ops/s
RawAllocationRate.arrayTest_C1        256  thrpt    5   5124.479 ± 548.617  ops/s
RawAllocationRate.arrayTest_C1       1024  thrpt    5   9459.376 ± 716.317  ops/s
RawAllocationRate.arrayTest_C1       2048  thrpt    5   9840.594 ±  15.922  ops/s
RawAllocationRate.arrayTest_C1       4096  thrpt    5   9860.274 ±  56.088  ops/s
RawAllocationRate.arrayTest_C1       8192  thrpt    5  13677.987 ± 143.048  ops/s
RawAllocationRate.arrayTest_C1      16384  thrpt    5  19517.416 ± 155.004  ops/s
RawAllocationRate.arrayTest_C1      65536  thrpt    5  37348.536 ± 307.582  ops/s
RawAllocationRate.arrayTest_C1     131072  thrpt    5  43414.399 ±  58.317  ops/s
RawAllocationRate.instanceTest         32  thrpt    5   6620.452 ± 137.048  ops/s
RawAllocationRate.instanceTest         64  thrpt    5   9850.677 ±   6.417  ops/s
RawAllocationRate.instanceTest        256  thrpt    5   5533.512 ± 129.334  ops/s
RawAllocationRate.instanceTest       1024  thrpt    5   9829.806 ±   7.555  ops/s
RawAllocationRate.instanceTest       2048  thrpt    5   9857.707 ±  51.541  ops/s
RawAllocationRate.instanceTest       4096  thrpt    5   9957.300 ±   7.115  ops/s
RawAllocationRate.instanceTest       8192  thrpt    5  13662.581 ±  85.225  ops/s
RawAllocationRate.instanceTest      16384  thrpt    5  19571.796 ± 120.962  ops/s
RawAllocationRate.instanceTest      65536  thrpt    5  37401.527 ±  67.260  ops/s
RawAllocationRate.instanceTest     131072  thrpt    5  43327.339 ±  35.077  ops/s
RawAllocationRate.instanceTest_C1      32  thrpt    5   2842.031 ±  47.924  ops/s
RawAllocationRate.instanceTest_C1      64  thrpt    5   5359.357 ±  53.031  ops/s
RawAllocationRate.instanceTest_C1     256  thrpt    5   5081.287 ±  57.737  ops/s
RawAllocationRate.instanceTest_C1    1024  thrpt    5   8372.330 ± 267.016  ops/s
RawAllocationRate.instanceTest_C1    2048  thrpt    5   9470.224 ± 250.706  ops/s
RawAllocationRate.instanceTest_C1    4096  thrpt    5   9843.936 ±  52.825  ops/s
RawAllocationRate.instanceTest_C1    8192  thrpt    5  13695.863 ±  80.433  ops/s
RawAllocationRate.instanceTest_C1   16384  thrpt    5  19495.110 ± 116.300  ops/s
RawAllocationRate.instanceTest_C1   65536  thrpt    5  37448.948 ± 291.917  ops/s
RawAllocationRate.instanceTest_C1  131072  thrpt    5  43443.406 ± 267.236  ops/s

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8270947: AArch64: C1: use zero_words to initialize all objects

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4919/head:pull/4919
$ git checkout pull/4919

Update a local copy of the PR:
$ git checkout pull/4919
$ git pull https://git.openjdk.java.net/jdk pull/4919/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4919

View PR using the GUI difftool:
$ git pr show -t 4919

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4919.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 28, 2021

👋 Welcome back aph! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 28, 2021

@theRealAph The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Jul 28, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 28, 2021
@mlbridge
Copy link

mlbridge bot commented Jul 28, 2021

Webrevs

@openjdk openjdk bot added rfr Pull request is ready for review and removed rfr Pull request is ready for review labels Jul 28, 2021
@theRealAph theRealAph closed this Jul 28, 2021
@theRealAph theRealAph reopened this Jul 28, 2021
@nick-arm
Copy link
Contributor

I hit the following assertion failure when I ran tier1 with -XX:TieredStopAtLevel=1. This was from compiler/loopopts/TestDeepGraphVerifyIterativeGVN.java.

#  Internal Error (/mnt/nicgas01-pc/jdk/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp:566), pid=124784, tid=124797
#  assert(pc() == ((address)::badAddressVal)) failed: postcond
V  [libjvm.so+0x12c1bbc]  MacroAssembler::trampoline_call(Address, CodeBuffer*)+0x2fc
V  [libjvm.so+0x12daf10]  MacroAssembler::zero_words(RegisterImpl*, RegisterImpl*)+0x130
V  [libjvm.so+0x79c950]  C1_MacroAssembler::initialize_body(RegisterImpl*, RegisterImpl*, int, RegisterImpl*, RegisterImpl*)+0x1b0
V  [libjvm.so+0x79daec]  C1_MacroAssembler::allocate_array(RegisterImpl*, RegisterImpl*, RegisterImpl*, RegisterImpl*, int, int, RegisterImpl*, Label&)+0x41c
V  [libjvm.so+0x73bad0]  LIR_Assembler::emit_alloc_array(LIR_OpAllocArray*)+0x160
V  [libjvm.so+0x71be40]  LIR_OpAllocArray::emit_code(LIR_Assembler*)+0x20
V  [libjvm.so+0x72c6e8]  LIR_Assembler::emit_lir_list(LIR_List*)+0xe8
V  [libjvm.so+0x72ce48]  LIR_Assembler::emit_code(BlockList*)+0x78
V  [libjvm.so+0x6d394c]  Compilation::emit_code_body()+0x14c
V  [libjvm.so+0x6d40a0]  Compilation::compile_java_method()+0x550

@nick-arm
Copy link
Contributor

I hit the following assertion failure when I ran tier1 with -XX:TieredStopAtLevel=1. This was from compiler/loopopts/TestDeepGraphVerifyIterativeGVN.java.

#  Internal Error (/mnt/nicgas01-pc/jdk/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp:566), pid=124784, tid=124797
#  assert(pc() == ((address)::badAddressVal)) failed: postcond

Maybe we need to reserve some extra space for the trampoline stubs in C1's Compilation::setup_code_buffer()? That assert seems dodgy though, pc() won't be badAddressVal if code()->blob() was initially NULL (the code buffer wasn't resizeable).

@mlbridge
Copy link

mlbridge bot commented Jul 29, 2021

Mailing list message from Andrew Haley on hotspot-dev:

On 7/29/21 9:56 AM, Nick Gasson wrote:

I hit the following assertion failure when I ran tier1 with `-XX:TieredStopAtLevel=1`. This was from `compiler/loopopts/TestDeepGraphVerifyIterativeGVN.java`.

# Internal Error (/mnt/nicgas01-pc/jdk/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp:566), pid=124784, tid=124797
# assert(pc() == ((address)::badAddressVal)) failed: postcond

Oh, that really is weird. I'll dig some more.

--
Andrew Haley (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671

@mlbridge
Copy link

mlbridge bot commented Jul 29, 2021

Mailing list message from Andrew Haley on hotspot-dev:

On 7/29/21 10:19 AM, Andrew Haley wrote:

On 7/29/21 9:56 AM, Nick Gasson wrote:

I hit the following assertion failure when I ran tier1 with `-XX:TieredStopAtLevel=1`. This was from `compiler/loopopts/TestDeepGraphVerifyIterativeGVN.java`.

# Internal Error (/mnt/nicgas01-pc/jdk/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp:566), pid=124784, tid=124797
# assert(pc() == ((address)::badAddressVal)) failed: postcond

Oh, that really is weird. I'll dig some more.

I get

Running test 'jtreg:test/hotspot/jtreg/compiler/loopopts/TestDeepGraphVerifyIterativeGVN.java'
Test results: no tests selected

perhaps because that is a C2-only test.

--
Andrew Haley (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671

@mlbridge
Copy link

mlbridge bot commented Jul 29, 2021

Mailing list message from Andrew Haley on hotspot-dev:

On 7/29/21 10:36 AM, Andrew Haley wrote:

perhaps because that is a C2-only test.

Ah no, it's a debug-only test.

--
Andrew Haley (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671

@mlbridge
Copy link

mlbridge bot commented Jul 29, 2021

Mailing list message from Nick Gasson on hotspot-dev:

On 29/07/21 17:36 pm, Andrew Haley wrote:

I get

Running test 'jtreg:test/hotspot/jtreg/compiler/loopopts/TestDeepGraphVerifyIterativeGVN.java'
Test results: no tests selected

perhaps because that is a C2-only test.

I did:

make exploded-test TEST="compiler/loopopts/TestDeepGraphVerifyIterativeGVN.java" \
JTREG="VM_OPTIONS=-XX:TieredStopAtLevel=1"

On a fastdebug build.

--
Nick

@mlbridge
Copy link

mlbridge bot commented Jul 29, 2021

Mailing list message from Andrew Haley on hotspot-dev:

On 7/29/21 10:58 AM, Nick Gasson wrote:

On 29/07/21 17:36 pm, Andrew Haley wrote:

I get

Running test 'jtreg:test/hotspot/jtreg/compiler/loopopts/TestDeepGraphVerifyIterativeGVN.java'
Test results: no tests selected

perhaps because that is a C2-only test.

I did:

make exploded-test TEST="compiler/loopopts/TestDeepGraphVerifyIterativeGVN.java" \
JTREG="VM_OPTIONS=-XX:TieredStopAtLevel=1"

On a fastdebug build.

Fascinating. C1 doesn't allocate any space for trampoline stubs, except for explicit call LIR.
Anyway, it makes sense to use far_call() in the case of C1 compilation: we want compilations
to be fast anyway.

Copy link
Contributor

@nick-arm nick-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and I've tested tier1 with -XX:TieredStopAtLevel=1. Although you probably ought to update the copyright year in c1_MacroAssembler_aarch64.hpp.

@openjdk
Copy link

openjdk bot commented Jul 30, 2021

@theRealAph This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270947: AArch64: C1: use zero_words to initialize all objects

Reviewed-by: ngasson, adinn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 59 new commits pushed to the master branch:

  • 89f5c96: 8232066: Remove outdated code/methods from PKIX implementation
  • 9856ace: 8268963: [IR Framework] Some default regexes matching on PrintOptoAssembly in IRNode.java do not work on all platforms
  • b59418f: 8270060: (jdeprscan) tools/jdeprscan/tests/jdk/jdeprscan/TestRelease.java failed with class file for jdk.internal.util.random.RandomSupport not found
  • 4f42eb6: 8269523: runtime/Safepoint/TestAbortOnVMOperationTimeout.java failed when expecting 'VM operation took too long'
  • 77fbd99: 8270341: Test serviceability/dcmd/gc/HeapDumpAllTest.java timed-out
  • 048fb2c: Merge
  • 286d313: 8271489: (doc) Clarify Filter Factory example
  • d09b028: 8271396: Spelling errors
  • 489e5fd: 8268019: C2: assert(no_dead_loop) failed: dead loop detected
  • 6afcf5f: 8270886: Crash in PhaseIdealLoop::verify_strip_mined_scheduling
  • ... and 49 more: https://git.openjdk.java.net/jdk/compare/515113d8589875e76980ebf7473cb81f778bb86f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 30, 2021
Copy link
Contributor

@adinn adinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@adinn
Copy link
Contributor

adinn commented Jul 30, 2021

My initial reaction to that extra last commit was that anything other than a compiler thread calling MacroAssembler::zero_words implies "Something is rotten in the state of Danmark" and the only end game is a stage strewn with corpses. Of course, zero_words gets called from the stub generator. However, I guess the stub complete check avoids any problems there.

Were you thinking of some other potential use for it? e.g. lazy intrinsics?

Anyway, the check certainly does no harm so it is all still good.

@mlbridge
Copy link

mlbridge bot commented Jul 30, 2021

Mailing list message from Andrew Haley on hotspot-dev:

On 7/30/21 4:55 PM, Andrew Dinn wrote:

My initial reaction to that extra last commit was that anything other than a compiler thread calling MacroAssembler::zero_words implies "Something is rotten in the state of Danmark" and the only end game is a stage strewn with corpses. Of course, zero_words gets called from the stub generator. However, I guess the stub complete check avoids any problems there.

Were you thinking of some other potential use for it? e.g. lazy intrinsics?

Anyway, the check certainly does no harm so it is all still good.

I *think* it's probably unnecessary. However, we do lazily generate IC
buffers from Java code, and we use the assembler to do that. So in general
it is not against any rules to use the MacroAssembler from non-compiler
threads.

It is certainly the case that you can't call ciEnv::current() unless
you're on a compiler thread without risking Severe Badness, because
current() blindly does this:

static CompilerThread* current() {
=> return CompilerThread::cast(JavaThread::current());
}
static CompilerThread* cast(Thread* t) {
assert(t->is_Compiler_thread(), "incorrect cast to CompilerThread");
return static_cast<CompilerThread*>(t);
}

And therefore ciEnv::current()->task() is Undefined Behaviour if not on a
CompilerThread.

(This is pretty awful, and I should submit a patch to perhaps add
ciEnv::current_orNull(). But not in this patch.)

So it's fairly uncontroversial, I would have thought, to guard
all calls to ciEnv::current() from MacroAssembler with is_Compiler_thread().

--
Andrew Haley (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671

@theRealAph
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 30, 2021

Going to push as commit 6c68ce2.
Since your change was applied there have been 62 commits pushed to the master branch:

  • cd7e30e: 8271242: Add Arena regression tests
  • 5b3c418: 8270321: Startup regressions in 18-b5 caused by JDK-8266310
  • baf7797: 8049301: Suspicious use of string identity checks in JComponent.setUIProperty
  • 89f5c96: 8232066: Remove outdated code/methods from PKIX implementation
  • 9856ace: 8268963: [IR Framework] Some default regexes matching on PrintOptoAssembly in IRNode.java do not work on all platforms
  • b59418f: 8270060: (jdeprscan) tools/jdeprscan/tests/jdk/jdeprscan/TestRelease.java failed with class file for jdk.internal.util.random.RandomSupport not found
  • 4f42eb6: 8269523: runtime/Safepoint/TestAbortOnVMOperationTimeout.java failed when expecting 'VM operation took too long'
  • 77fbd99: 8270341: Test serviceability/dcmd/gc/HeapDumpAllTest.java timed-out
  • 048fb2c: Merge
  • 286d313: 8271489: (doc) Clarify Filter Factory example
  • ... and 52 more: https://git.openjdk.java.net/jdk/compare/515113d8589875e76980ebf7473cb81f778bb86f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 30, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 30, 2021
@openjdk
Copy link

openjdk bot commented Jul 30, 2021

@theRealAph Pushed as commit 6c68ce2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
3 participants