8253960: Memory leak in Java_java_lang_ClassLoader_defineClass0()

[zhengyu123]

The memory leak is quite obvious. Early return results 'body' not been released.

Test:

• tier1 on Linux x86_64

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8253960: Memory leak in Java_java_lang_ClassLoader_defineClass0()

Reviewers

• Mandy Chung (@mlchung - Reviewer)
• Thomas Stuefe (@tstuefe - Reviewer)
• Alan Bateman (@AlanBateman - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/492/head:pull/492
$ git checkout pull/492

[bridgekeeper]

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[zhengyu123]

/label add core-libs
/label add hotspot-runtime

[openjdk]

@zhengyu123
The core-libs label was successfully added.

[openjdk]

@zhengyu123
The hotspot-runtime label was successfully added.

[mlbridge]

Webrevs

• 00: Full (7dd251b)

[mlchung]

Thanks for catching this. Looks good.

[openjdk]

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8253960: Memory leak in Java_java_lang_ClassLoader_defineClass0()

Reviewed-by: mchung, stuefe, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 50 new commits pushed to the master branch:

• d296708: 8253606: Need to add missed constructor to the SwingEventMonitor
• 5810238: 8253945: Missed default constructor for StreamPrintServiceFactory.java
• 123e786: 8239105: Add exception for expiring Digicert root certificates to VerifyCACerts test
• 22f0916: 8253938: ZGC: Clean up argument names after JDK-8253030
• 7778047: 8253736: Cleanup some of WorkArounds and usage thereof
• 87d77eb: 8253879: Simplify redundant code in IndexBuilder
• dffe9db: 8252537: Updated @exception with @throws
• 406db1c: 8253913: unify gtest test names
• ea5a2b1: 8251464: make Node::dump(int depth) support indent
• fff8c8d: 8253882: remove PropertyResolvingWrapper
• ... and 40 more: https://git.openjdk.java.net/jdk/compare/8cf8e463c623b3908befb0af289749b47a793267...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tstuefe]

Look good!

[AlanBateman]

Should this be renamed to "Memory leak in Lookup.defineClass"? I don't think it impacts anything extending or using the ClassLoader.

[zhengyu123]

/integrate

[openjdk]

@zhengyu123 Since your change was applied there have been 54 commits pushed to the master branch:

• 5d4a135: 8253842: [JVMCI] Allow implicit exception to dispatch to other address in jvmci compilers.
• 289ae79: 8252998: ModuleWrapper.gmk doesn't consult include path
• 9604ee8: 8248238: Implementation: JEP 388: Windows AArch64 Support
• 1c2754b: 8253269: The CheckCommonColors test should provide more info on failure
• d296708: 8253606: Need to add missed constructor to the SwingEventMonitor
• 5810238: 8253945: Missed default constructor for StreamPrintServiceFactory.java
• 123e786: 8239105: Add exception for expiring Digicert root certificates to VerifyCACerts test
• 22f0916: 8253938: ZGC: Clean up argument names after JDK-8253030
• 7778047: 8253736: Cleanup some of WorkArounds and usage thereof
• 87d77eb: 8253879: Simplify redundant code in IndexBuilder
• ... and 44 more: https://git.openjdk.java.net/jdk/compare/8cf8e463c623b3908befb0af289749b47a793267...master

Your commit was automatically rebased without conflicts.

Pushed as commit 19219a9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.