Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271352: Extend jcc erratum mitigation to additional processors #4922

Closed
wants to merge 1 commit into from

Conversation

kimbarrett
Copy link

@kimbarrett kimbarrett commented Jul 28, 2021

Please review this change to default enable the Intel jcc erratum
performance mitigation for family 6 model 165 (0xA5). This seems to reduce
the frequency of an issue that is still under investigation.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8271352: Extend jcc erratum mitigation to additional processors

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4922/head:pull/4922
$ git checkout pull/4922

Update a local copy of the PR:
$ git checkout pull/4922
$ git pull https://git.openjdk.java.net/jdk pull/4922/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4922

View PR using the GUI difftool:
$ git pr show -t 4922

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4922.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 28, 2021

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 28, 2021
@openjdk
Copy link

openjdk bot commented Jul 28, 2021

@kimbarrett The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Jul 28, 2021
@mlbridge
Copy link

mlbridge bot commented Jul 28, 2021

Webrevs

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

@openjdk
Copy link

openjdk bot commented Jul 28, 2021

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271352: Extend jcc erratum mitigation to additional processors

Reviewed-by: thartmann, eosterlund

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 28, 2021
@kimbarrett
Copy link
Author

Withdrawing this. I accidentally opened this PR against mainline, rather than the intended jdk17 repo.

@kimbarrett kimbarrett closed this Jul 28, 2021
@kimbarrett kimbarrett deleted the model_a5 branch July 28, 2021 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org ready Pull request is ready to be integrated rfr Pull request is ready for review
3 participants