8232066: Remove outdated code/methods from PKIX implementation

[seanjmullan]

Please review this fix to remove the Validator.VAR_PLUGIN_CODE_SIGNING variant and related code that is no longer needed in the PKIX implementation.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8232066: Remove outdated code/methods from PKIX implementation

Reviewers

• Weijun Wang (@wangweij - Reviewer) ⚠️ Review applies to 52be3dd

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4934/head:pull/4934
$ git checkout pull/4934

Update a local copy of the PR:
$ git checkout pull/4934
$ git pull https://git.openjdk.java.net/jdk pull/4934/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4934

View PR using the GUI difftool:
$ git pr show -t 4934

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4934.diff

[bridgekeeper]

👋 Welcome back mullan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@seanjmullan The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (b388bb4b)
• 00: Full (52be3dd2)

[wangweij]

Looks good. One nit: Validator::getInstance methods are internal. Does it really matter to check for null?

[openjdk]

@seanjmullan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8232066: Remove outdated code/methods from PKIX implementation

Reviewed-by: weijun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 35 new commits pushed to the master branch:

• d09b028: 8271396: Spelling errors
• 489e5fd: 8268019: C2: assert(no_dead_loop) failed: dead loop detected
• 6afcf5f: 8270886: Crash in PhaseIdealLoop::verify_strip_mined_scheduling
• a0504cf: Merge
• 20d2dc1: 8271403: mark hotspot runtime/memory tests which ignore external VM flags
• e593e3d: 8271402: mark hotspot runtime/os tests which ignore external VM flags
• 7bf72ce: 8271412: ProblemList javax/sound/midi/Sequencer/Looping.java
• 6878b05: 8271251: JavaThread::java_suspend() fails with "fatal error: Illegal threadstate encountered: 6"
• c8ae7e5: 8271174: runtime/ClassFile/UnsupportedClassFileVersion.java can be run in driver mode
• 5fcf720: 8271352: Extend jcc erratum mitigation to additional processors
• ... and 25 more: https://git.openjdk.java.net/jdk/compare/fc80a6b49364594fafa0e2efc769d2f6234cfa22...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[seanjmullan]

Looks good. One nit: Validator::getInstance methods are internal. Does it really matter to check for null?

Good point. Also, NPE will be thrown later when an EndEntityChecker is invoked and it needs to determine the variant to use. However, I had to change the ConstructorTest test not to test for this case anymore.

[seanjmullan]

/integrate

[openjdk]

Going to push as commit 89f5c96.
Since your change was applied there have been 41 commits pushed to the master branch:

• 9856ace: 8268963: [IR Framework] Some default regexes matching on PrintOptoAssembly in IRNode.java do not work on all platforms
• b59418f: 8270060: (jdeprscan) tools/jdeprscan/tests/jdk/jdeprscan/TestRelease.java failed with class file for jdk.internal.util.random.RandomSupport not found
• 4f42eb6: 8269523: runtime/Safepoint/TestAbortOnVMOperationTimeout.java failed when expecting 'VM operation took too long'
• 77fbd99: 8270341: Test serviceability/dcmd/gc/HeapDumpAllTest.java timed-out
• 048fb2c: Merge
• 286d313: 8271489: (doc) Clarify Filter Factory example
• d09b028: 8271396: Spelling errors
• 489e5fd: 8268019: C2: assert(no_dead_loop) failed: dead loop detected
• 6afcf5f: 8270886: Crash in PhaseIdealLoop::verify_strip_mined_scheduling
• a0504cf: Merge
• ... and 31 more: https://git.openjdk.java.net/jdk/compare/fc80a6b49364594fafa0e2efc769d2f6234cfa22...master

Your commit was automatically rebased without conflicts.

[openjdk]

@seanjmullan Pushed as commit 89f5c96.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.