Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8270116: Expand ButtonGroupLayoutTraversalTest.java to run in all LaFs, including Aqua on macOS #4937

Closed
wants to merge 2 commits into from

Conversation

rajamah
Copy link
Contributor

@rajamah rajamah commented Jul 29, 2021

Summary: Expanded ButtonGroupLayoutTraversalTest.java to run in all LAFs on all OS. Added synchronization for focusCnt.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8270116: Expand ButtonGroupLayoutTraversalTest.java to run in all LaFs, including Aqua on macOS

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4937/head:pull/4937
$ git checkout pull/4937

Update a local copy of the PR:
$ git checkout pull/4937
$ git pull https://git.openjdk.java.net/jdk pull/4937/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4937

View PR using the GUI difftool:
$ git pr show -t 4937

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4937.diff

…s, including Aqua on macOS

Summary: Expaneded ButtonGroupLayoutTraversalTest.java to run in all LAFs on all OS. Added synchronization for focusCnt.
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 29, 2021

👋 Welcome back rajamah! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jul 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 29, 2021

@rajamah The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the awt label Jul 29, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 29, 2021

Webrevs

Copy link
Contributor

@prsadhuk prsadhuk left a comment

Also, please give a CI run of this test running for several iterations(20+) for all platforms since it's supposed to be run in all L&Fs and post in JBS.

@@ -50,98 +51,113 @@

public class ButtonGroupLayoutTraversalTest {

static int nx = 3;
static int ny = 3;
private static final int nx = 3;
Copy link
Contributor

@prsadhuk prsadhuk Jul 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally, as per coding standard, for static final modifier, the variable should be named in CAPS...but is there any need of making it final?

Copy link
Contributor Author

@rajamah rajamah Jul 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran test 20 times on all OS and it passed, posted link in JBS. I avoided changing to CAPS to prevent code change noise and final is done since these variable values don't change or are constant throughout the code and we want it that way.

Copy link
Contributor Author

@rajamah rajamah Aug 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prsadhuk I did what you asked, do you have any more questions or comments ?, if not could you please approve this PR, thanks.

Copy link
Contributor

@prsadhuk prsadhuk Aug 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think nx, ny should be made CAPS...It seems to be the case for static final constant variables in java/awt test folder...I don't think it will increase noise as it will impact only in l57

Copy link
Member

@aivanov-jdk aivanov-jdk Aug 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will affect more lines; these constants are used in for-loops to move focus between buttons as well as to validate the results. Let it be.

Copy link
Contributor Author

@rajamah rajamah Aug 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated nx, ny with CAPS version.

Copy link
Member

@aivanov-jdk aivanov-jdk left a comment

Looks good to me.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 30, 2021

⚠️ @rajamah the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout 8270116
$ git commit -c user.name='Preferred Full Name' --allow-empty -m 'Update full name'
$ git push

@openjdk
Copy link

@openjdk openjdk bot commented Jul 30, 2021

@rajamah This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270116: Expand ButtonGroupLayoutTraversalTest.java to run in all LaFs, including Aqua on macOS

Reviewed-by: psadhukhan, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 121 new commits pushed to the master branch:

  • 3ab95d1: 8271905: mark hotspot runtime/Metaspace tests which ignore external VM flags
  • e2c5bfe: 8271308: (fc) FileChannel.transferTo() transfers no more than Integer.MAX_VALUE bytes in one call
  • 7234a43: 8271953: fix mis-merge in JDK-8271878
  • d7fc9e4: 8267840: Improve URLStreamHandler.parseURL()
  • 55bd52a: 8271840: Add simple Integer.toString microbenchmarks
  • 18dd4d4: 8271121: ZGC: stack overflow (segv) when -Xlog:gc+start=debug
  • 685fc3c: 8270903: sun.net.httpserver.HttpConnection: Improve toString
  • 4abe531: 8271722: [TESTBUG] gc/g1/TestMixedGCLiveThreshold.java can fail if G1 Full GC uses >1 workers
  • ea9a595: 8270058: Use Objects.check{Index,FromIndexSize} for java.desktop
  • 64d18d4: 4819544: SwingSet2 JTable Demo throws NullPointerException
  • ... and 111 more: https://git.openjdk.java.net/jdk/compare/90cd2fa16458dcc3e36171fa4bf21f26bc92b168...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prsadhuk, @aivanov-jdk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Jul 30, 2021
@rajamah
Copy link
Contributor Author

@rajamah rajamah commented Aug 5, 2021

/integrate

@openjdk openjdk bot added the sponsor label Aug 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 5, 2021

@rajamah
Your change (at version b05f3d4) is now ready to be sponsored by a Committer.

@aivanov-jdk
Copy link
Member

@aivanov-jdk aivanov-jdk commented Aug 5, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Aug 5, 2021

Going to push as commit cb36880.
Since your change was applied there have been 121 commits pushed to the master branch:

  • 3ab95d1: 8271905: mark hotspot runtime/Metaspace tests which ignore external VM flags
  • e2c5bfe: 8271308: (fc) FileChannel.transferTo() transfers no more than Integer.MAX_VALUE bytes in one call
  • 7234a43: 8271953: fix mis-merge in JDK-8271878
  • d7fc9e4: 8267840: Improve URLStreamHandler.parseURL()
  • 55bd52a: 8271840: Add simple Integer.toString microbenchmarks
  • 18dd4d4: 8271121: ZGC: stack overflow (segv) when -Xlog:gc+start=debug
  • 685fc3c: 8270903: sun.net.httpserver.HttpConnection: Improve toString
  • 4abe531: 8271722: [TESTBUG] gc/g1/TestMixedGCLiveThreshold.java can fail if G1 Full GC uses >1 workers
  • ea9a595: 8270058: Use Objects.check{Index,FromIndexSize} for java.desktop
  • 64d18d4: 4819544: SwingSet2 JTable Demo throws NullPointerException
  • ... and 111 more: https://git.openjdk.java.net/jdk/compare/90cd2fa16458dcc3e36171fa4bf21f26bc92b168...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 5, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Aug 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 5, 2021

@aivanov-jdk @rajamah Pushed as commit cb36880.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awt integrated
3 participants