Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253269: The CheckCommonColors test should provide more info on failure #494

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Oct 3, 2020

This test fails from time to time on Linux in mach5.

I was able to reproduce it on one of the hosts and confirm that the root cause was in the slow
systems, which could not complete show/repaint/show/repaint actions in time.
After the fix the test will wait a little bit longer and request a repaint on each falied attempt.

I am also added and additional logging to make possible bugs evaluations easy.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253269: The CheckCommonColors test should provide more info on failure

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/494/head:pull/494
$ git checkout pull/494

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 3, 2020

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 3, 2020
@openjdk
Copy link

openjdk bot commented Oct 3, 2020

@mrserb The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the awt client-libs-dev@openjdk.org label Oct 3, 2020
@mlbridge
Copy link

mlbridge bot commented Oct 3, 2020

Webrevs

prrace
prrace approved these changes Oct 3, 2020
@openjdk
Copy link

openjdk bot commented Oct 3, 2020

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8253269: The CheckCommonColors test should provide more info on failure

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 3, 2020
@mrserb
Copy link
Member Author

mrserb commented Oct 3, 2020

/integrate

@openjdk openjdk bot closed this Oct 3, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 3, 2020
@openjdk
Copy link

openjdk bot commented Oct 3, 2020

@mrserb Pushed as commit 1c2754b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the JDK-8253269 branch Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awt client-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants