Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266079: Lanai: AlphaComposite shows differences on Metal compared to OpenGL #4946

Closed
wants to merge 2 commits into from

Conversation

@avu
Copy link

@avu avu commented Jul 30, 2021

Keep MTLLayer opacity in sync with window content view
Keep layer translucent for translucent windows


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8266079: Lanai: AlphaComposite shows differences on Metal compared to OpenGL

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4946/head:pull/4946
$ git checkout pull/4946

Update a local copy of the PR:
$ git checkout pull/4946
$ git pull https://git.openjdk.java.net/jdk pull/4946/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4946

View PR using the GUI difftool:
$ git pr show -t 4946

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4946.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 30, 2021

👋 Welcome back avu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jul 30, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 30, 2021

@avu The following labels will be automatically applied to this pull request:

  • 2d
  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 30, 2021

Webrevs

… OpenGL

Keep MTLLayer opacity in sync with window content view
Keep layer translucent for translucent windows
Update opacity on textured property change
Make native MTLLayer opaque by default to match java component state
… OpenGL

Removed unnecessary initialisation of opacity
mrserb
mrserb approved these changes Aug 13, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 13, 2021

@avu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266079: Lanai: AlphaComposite shows differences on Metal compared to OpenGL

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

  • bd7f9b4: 8272459: ProblemList compiler/codecache/TestStressCodeBuffers.java on aarch64
  • 717792c: 8263940: NPE when creating default file system when default file system provider is packaged as JAR file on class path
  • d06d0b9: 8272112: Arena code simplifications
  • 0c4be76: 8058704: Nimbus does not honor JTextPane background color
  • 020aec5: 8271366: [REDO] JDK-8266054 VectorAPI rotate operation optimization
  • 4d4ba5c: 8272116: Update PerfDisableSharedMem with FLAG_SET_ERGO in PerfMemory::create_memory_region
  • 09ab86b: 8269909: getStack method in hprof.parser.Reader should use try-with-resource
  • e4766ee: 8272391: Undeleted debug information
  • 428d516: 8140241: (fc) Data transfer from FileChannel to itself causes hang in case of overlap
  • 93cab7d: 8272315: Improve assert_different_registers
  • ... and 15 more: https://git.openjdk.java.net/jdk/compare/cd1751c34e974683f3d2734c8ad5823a6ea27295...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 13, 2021
@avu
Copy link
Author

@avu avu commented Aug 14, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Aug 14, 2021

Going to push as commit 17b9350.
Since your change was applied there have been 28 commits pushed to the master branch:

  • 87d2761: 8271883: Math CopySign optimization for x86
  • 6b8b160: 8272396: mismatching debug output streams
  • 0af645a: 8205138: Remove Applet references from Font2DTest
  • bd7f9b4: 8272459: ProblemList compiler/codecache/TestStressCodeBuffers.java on aarch64
  • 717792c: 8263940: NPE when creating default file system when default file system provider is packaged as JAR file on class path
  • d06d0b9: 8272112: Arena code simplifications
  • 0c4be76: 8058704: Nimbus does not honor JTextPane background color
  • 020aec5: 8271366: [REDO] JDK-8266054 VectorAPI rotate operation optimization
  • 4d4ba5c: 8272116: Update PerfDisableSharedMem with FLAG_SET_ERGO in PerfMemory::create_memory_region
  • 09ab86b: 8269909: getStack method in hprof.parser.Reader should use try-with-resource
  • ... and 18 more: https://git.openjdk.java.net/jdk/compare/cd1751c34e974683f3d2734c8ad5823a6ea27295...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 14, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 14, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 14, 2021

@avu Pushed as commit 17b9350.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants