New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8271605: Update JMH devkit to 1.32 #4954
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@shipilev This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 255 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks.
Thanks! (and welcome back, Claes) /integrate |
Going to push as commit e74537f.
Your commit was automatically rebased without conflicts. |
You're welcome - and thanks! Good to be back.. |
It is currently at 1.28, and thus misses a bunch of fixes and improvements. 1.32 is the latest version, and probably the last version before enabling the automatic detection of compiler blackholes (CODETOOLS-7903004), the change that would affect benchmarks performance.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4954/head:pull/4954
$ git checkout pull/4954
Update a local copy of the PR:
$ git checkout pull/4954
$ git pull https://git.openjdk.java.net/jdk pull/4954/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4954
View PR using the GUI difftool:
$ git pr show -t 4954
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4954.diff