Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271609: Misleading message for AbortVMOnVMOperationTimeoutDelay #4955

wants to merge 1 commit into from


Copy link

@albertnetymk albertnetymk commented Aug 2, 2021

Simple amendment to AbortVMOnVMOperationTimeoutDelay message to avoid misinterpretation.


  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed


  • JDK-8271609: Misleading message for AbortVMOnVMOperationTimeoutDelay



Using git

Checkout this PR locally:
$ git fetch pull/4955/head:pull/4955
$ git checkout pull/4955

Update a local copy of the PR:
$ git checkout pull/4955
$ git pull pull/4955/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4955

View PR using the GUI difftool:
$ git pr show -t 4955

Using diff file

Download this PR as a diff file:

Copy link

@bridgekeeper bridgekeeper bot commented Aug 2, 2021

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Aug 2, 2021
Copy link

@openjdk openjdk bot commented Aug 2, 2021

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime label Aug 2, 2021
Copy link

@mlbridge mlbridge bot commented Aug 2, 2021


Copy link

@dholmes-ora dholmes-ora left a comment

Hi Albert,

Looks fine and trivial.


Copy link

@openjdk openjdk bot commented Aug 2, 2021

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file for details.

After integration, the commit message for the final commit will be:

8271609: Misleading message for AbortVMOnVMOperationTimeoutDelay

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 249d641: 8263561: Re-examine uses of LinkedList
  • 6a3f834: 8268113: Re-use Long.hashCode() where possible
  • 2536e43: 8270160: Remove redundant bounds check from AbstractStringBuilder.charAt()
  • 6c4c48f: 8266972: Use String.concat() in j.l.Class where invokedynamic-based String concatenation is not available
  • 72145f3: 8269665: Clean-up toString() methods of some primitive wrappers

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 2, 2021
Copy link
Member Author

@albertnetymk albertnetymk commented Aug 3, 2021

Thanks for the review.


Copy link

@openjdk openjdk bot commented Aug 3, 2021

Going to push as commit b217a6c.
Since your change was applied there have been 16 commits pushed to the master branch:

  • c8add22: Merge
  • ada58d1: 8067223: [TESTBUG] Rename Whitebox API package
  • f8fb571: 8271150: Remove EA from JDK 17 version string starting with Initial RC promotion on Aug 5, 2021(B34)
  • 84f0231: 8271419: Refactor test code for modifying CDS archive contents
  • 0b95394: 8271624: Avoid unnecessary ThreadGroup.checkAccess calls when creating Threads
  • e621cff: 8271627: Use local field access in favor of Class.getClassLoader0
  • 0a85236: 8193559: ugly DO_JAVA_THREADS macro should be replaced
  • db950ca: 8271348: Add stronger sanity check of thread state when polling for safepoint/handshakes
  • 3e3051e: 8251329: (zipfs) Files.walkFileTree walks infinitely if zip has dir named "." inside
  • 7a4c754: 8271611: Use SecurityConstants.ACCESS_PERMISSION in MethodHandles
  • ... and 6 more:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 3, 2021
@openjdk openjdk bot added the integrated label Aug 3, 2021
@albertnetymk albertnetymk deleted the abort-msg branch Aug 3, 2021
@openjdk openjdk bot removed ready rfr labels Aug 3, 2021
Copy link

@openjdk openjdk bot commented Aug 3, 2021

@albertnetymk Pushed as commit b217a6c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
hotspot-runtime integrated
2 participants