New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8271609: Misleading message for AbortVMOnVMOperationTimeoutDelay #4955
Conversation
|
@albertnetymk The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Albert,
Looks fine and trivial.
Thanks,
David
@albertnetymk This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
|
Thanks for the review. /integrate |
Going to push as commit b217a6c.
Your commit was automatically rebased without conflicts. |
@albertnetymk Pushed as commit b217a6c. |
Simple amendment to
AbortVMOnVMOperationTimeoutDelay
message to avoid misinterpretation.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4955/head:pull/4955
$ git checkout pull/4955
Update a local copy of the PR:
$ git checkout pull/4955
$ git pull https://git.openjdk.java.net/jdk pull/4955/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4955
View PR using the GUI difftool:
$ git pr show -t 4955
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4955.diff