Skip to content

8271611: Use SecurityConstants.ACCESS_PERMISSION in MethodHandles#4957

Closed
cl4es wants to merge 1 commit intoopenjdk:masterfrom
cl4es:thread_permission
Closed

8271611: Use SecurityConstants.ACCESS_PERMISSION in MethodHandles#4957
cl4es wants to merge 1 commit intoopenjdk:masterfrom
cl4es:thread_permission

Conversation

@cl4es
Copy link
Member

@cl4es cl4es commented Aug 2, 2021

Reusing SecurityConstants.ACCESS_PERMISSION (which was moved from AccessibleObject by JDK-8202419) avoids initialization of ReflectPermission when no SecurityManager is installed


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8271611: Use SecurityConstants.ACCESS_PERMISSION in MethodHandles

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4957/head:pull/4957
$ git checkout pull/4957

Update a local copy of the PR:
$ git checkout pull/4957
$ git pull https://git.openjdk.java.net/jdk pull/4957/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4957

View PR using the GUI difftool:
$ git pr show -t 4957

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4957.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 2, 2021

👋 Welcome back redestad! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 2, 2021
@openjdk
Copy link

openjdk bot commented Aug 2, 2021

@cl4es The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Aug 2, 2021
@mlbridge
Copy link

mlbridge bot commented Aug 2, 2021

Webrevs

Copy link
Contributor

@RogerRiggs RogerRiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Aug 2, 2021

@cl4es This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271611: Use SecurityConstants.ACCESS_PERMISSION in MethodHandles

Reviewed-by: rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 249d641: 8263561: Re-examine uses of LinkedList
  • 6a3f834: 8268113: Re-use Long.hashCode() where possible
  • 2536e43: 8270160: Remove redundant bounds check from AbstractStringBuilder.charAt()
  • 6c4c48f: 8266972: Use String.concat() in j.l.Class where invokedynamic-based String concatenation is not available
  • 72145f3: 8269665: Clean-up toString() methods of some primitive wrappers

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 2, 2021
@cl4es
Copy link
Member Author

cl4es commented Aug 2, 2021

Thanks for the review @RogerRiggs!

/integrate

@openjdk
Copy link

openjdk bot commented Aug 2, 2021

Going to push as commit 7a4c754.
Since your change was applied there have been 6 commits pushed to the master branch:

  • e74537f: 8271605: Update JMH devkit to 1.32
  • 249d641: 8263561: Re-examine uses of LinkedList
  • 6a3f834: 8268113: Re-use Long.hashCode() where possible
  • 2536e43: 8270160: Remove redundant bounds check from AbstractStringBuilder.charAt()
  • 6c4c48f: 8266972: Use String.concat() in j.l.Class where invokedynamic-based String concatenation is not available
  • 72145f3: 8269665: Clean-up toString() methods of some primitive wrappers

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 2, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 2, 2021
@openjdk
Copy link

openjdk bot commented Aug 2, 2021

@cl4es Pushed as commit 7a4c754.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants