Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271627: Use local field access in favor of Class.getClassLoader0 #4960

Closed
wants to merge 3 commits into from

Conversation

cl4es
Copy link
Member

@cl4es cl4es commented Aug 2, 2021

Trivial startup hack/cleanup to use the classLoader field directly rather than the getClassLoader0 accessor.

Before aa12c8f there was no classLoader field and getClassLoader0 was a native method that retrieved the ClassLoader by calling into the runtime. However, now that classLoader is injected on mirror creation it makes less sense to use the accessor when not necessary.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8271627: Use local field access in favor of Class.getClassLoader0

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4960/head:pull/4960
$ git checkout pull/4960

Update a local copy of the PR:
$ git checkout pull/4960
$ git pull https://git.openjdk.java.net/jdk pull/4960/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4960

View PR using the GUI difftool:
$ git pr show -t 4960

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4960.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 2, 2021

👋 Welcome back redestad! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@cl4es cl4es marked this pull request as ready for review Aug 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 2, 2021

@cl4es The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs rfr labels Aug 2, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 2, 2021

Webrevs

mlchung
mlchung approved these changes Aug 2, 2021
Copy link
Member

@mlchung mlchung left a comment

This looks okay. I assume you concern about the early startup when this method is running in interpreted mode. Do you see any startup improvement by this change?

@openjdk
Copy link

@openjdk openjdk bot commented Aug 2, 2021

@cl4es This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271627: Use local field access in favor of Class.getClassLoader0

Reviewed-by: mchung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 2, 2021
@cl4es
Copy link
Member Author

@cl4es cl4es commented Aug 2, 2021

Do you see any startup improvement by this change?

Very tiny, ~90 calls on bootstrap.

This looks okay.

Thanks!

I assume you concern about the early startup when this method is running in interpreted mode. Do you see any startup improvement by this change?

Yes. Many of these things that will be executed only when loading and bootstrapping, so might be interpreted for most of a JVM lifecycle. Right off the bat see a thousand or so less bytecode get executed on a hello world with this patch.

@cl4es
Copy link
Member Author

@cl4es cl4es commented Aug 2, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Aug 2, 2021

Going to push as commit e621cff.

@openjdk openjdk bot closed this Aug 2, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 2, 2021

@cl4es Pushed as commit e621cff.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs integrated
2 participants