JDK-8271721: Split gc/g1/TestMixedGCLiveThreshold into separate tests

[tstuefe]

Hi, may I please have reviews for this trivial change:

TestMixedGCLiveThreshold executes three tests in one by spawning off three child processes sequentially. In order to make the tests easier to analyze and to be able to execute them concurrently it would be helpful to have three subtests instead.

I also added diagnostic output.

Note: this was motivated while looking at test errors on ppc similar to JDK-8211081.

..Thomas

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8271721: Split gc/g1/TestMixedGCLiveThreshold into separate tests

Reviewers

• Thomas Schatzl (@tschatzl - Reviewer)
• Richard Reingruber (@reinrich - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4968/head:pull/4968
$ git checkout pull/4968

Update a local copy of the PR:
$ git checkout pull/4968
$ git pull https://git.openjdk.java.net/jdk pull/4968/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4968

View PR using the GUI difftool:
$ git pr show -t 4968

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4968.diff

[bridgekeeper]

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tstuefe The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (b3a98b08)

[tschatzl]

Lgtm.

[openjdk]

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271721: Split gc/g1/TestMixedGCLiveThreshold into separate tests

Reviewed-by: tschatzl, rrich

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• c8add22: Merge
• ada58d1: 8067223: [TESTBUG] Rename Whitebox API package
• f8fb571: 8271150: Remove EA from JDK 17 version string starting with Initial RC promotion on Aug 5, 2021(B34)
• 84f0231: 8271419: Refactor test code for modifying CDS archive contents
• 0b95394: 8271624: Avoid unnecessary ThreadGroup.checkAccess calls when creating Threads
• e621cff: 8271627: Use local field access in favor of Class.getClassLoader0
• 0a85236: 8193559: ugly DO_JAVA_THREADS macro should be replaced
• db950ca: 8271348: Add stronger sanity check of thread state when polling for safepoint/handshakes
• 3e3051e: 8251329: (zipfs) Files.walkFileTree walks infinitely if zip has dir named "." inside
• 7a4c754: 8271611: Use SecurityConstants.ACCESS_PERMISSION in MethodHandles
• ... and 1 more: https://git.openjdk.java.net/jdk/compare/249d641889c6f9aed6957502d5fca9c74c9baceb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tstuefe]

Lgtm.

Thank you, Thomas.

Is this trivial enough to be trivial?

[tschatzl]

While it is a very simple change, it does not qualify as "trivial" as per openjdk rules to skip the 24h rule imho. There also seems to be no rush in getting this change in either.

[tstuefe]

Okay, no problem.
Thanks, Thomas

[reinrich]

Looks good to me.

Cheers, Richard.

[tstuefe]

Looks good to me.

Cheers, Richard.

Thanks! I'll wait the obligatory 24hrs and push tomorrow.

[tstuefe]

/integrate

[openjdk]

Going to push as commit 66c653c.
Since your change was applied there have been 24 commits pushed to the master branch:

• 68dd828: 8271224: runtime/EnclosingMethodAttr/EnclMethodAttr.java doesn't check exit code
• 34ba70a: 8269037: jsig/Testjsig.java doesn't have to be restricted to linux only
• 7e518f4: 8269934: RunThese24H.java failed with EXCEPTION_ACCESS_VIOLATION in java_lang_Thread::get_thread_status
• 659498a: 8271829: mark hotspot runtime/Throwable tests which ignore external VM flags
• d3b40cb: 8271826: mark hotspot runtime/condy tests which ignore external VM flags
• 3435d29: 8271003: hs_err improvement: handle CLASSPATH env setting longer than O_BUFLEN
• 43a6ba9: 8271726: JFR: should use equal() to check event fields in tests
• a840870: 8271616: oddPart in MutableBigInteger::mutableModInverse contains info on final result
• 0199b03: 8271344: Windows product version issue
• 6594d3a: 8271711: Remove WorkArounds.isSynthetic
• ... and 14 more: https://git.openjdk.java.net/jdk/compare/249d641889c6f9aed6957502d5fca9c74c9baceb...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tstuefe Pushed as commit 66c653c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.