Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271722: [TESTBUG] gc/g1/TestMixedGCLiveThreshold.java can fail if G1 Full GC uses >1 workers #4971

Conversation

@reinrich
Copy link
Contributor

@reinrich reinrich commented Aug 3, 2021

I tried to make this pr is dependent on #4968. Hope this works...

The change fixes a test issue in gc/g1/TestMixedGCLiveThreshold.java by adding
the option -XX:ParallelGCThreads=1. This prevents the full gc from running
with more than one worker because if it would do that, live data could be
distributed into several regions and one of them could be selected for
collection which is unexpected with -XX:G1MixedGCLiveThresholdPercent=25.

Please refer to the JBS-Item for more details.

Thanks, Richard.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8271722: [TESTBUG] gc/g1/TestMixedGCLiveThreshold.java can fail if G1 Full GC uses >1 workers

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4971/head:pull/4971
$ git checkout pull/4971

Update a local copy of the PR:
$ git checkout pull/4971
$ git pull https://git.openjdk.java.net/jdk pull/4971/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4971

View PR using the GUI difftool:
$ git pr show -t 4971

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4971.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 3, 2021

👋 Welcome back rrich! A progress list of the required criteria for merging this PR into pr/4968 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 3, 2021

@reinrich The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the hotspot-gc label Aug 3, 2021
@reinrich
Copy link
Contributor Author

@reinrich reinrich commented Aug 3, 2021

/cc gc

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 3, 2021

@reinrich The label gc is not a valid label. These labels are valid:

  • serviceability
  • hotspot
  • sound
  • hotspot-compiler
  • ide-support
  • kulla
  • i18n
  • shenandoah
  • jdk
  • javadoc
  • security
  • 2d
  • swing
  • hotspot-runtime
  • jmx
  • nio
  • build
  • beans
  • core-libs
  • compiler
  • net
  • hotspot-gc
  • hotspot-jfr
  • awt

Loading

@reinrich reinrich marked this pull request as ready for review Aug 3, 2021
@openjdk openjdk bot added the rfr label Aug 3, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 3, 2021

Webrevs

Loading

Copy link
Contributor

@tschatzl tschatzl left a comment

Lgtm.

Loading

@NikolayTach
Copy link

@NikolayTach NikolayTach commented Aug 3, 2021

Can use curl to watch this?

Loading

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/4968 to master Aug 4, 2021
@openjdk-notifier
Copy link

@openjdk-notifier openjdk-notifier bot commented Aug 4, 2021

The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout JDK-8271721-split-TestMixedGCLiveThreshold
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 4, 2021

@reinrich This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271722: [TESTBUG] gc/g1/TestMixedGCLiveThreshold.java can fail if G1 Full GC uses >1 workers

Reviewed-by: ayang, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Aug 4, 2021
@reinrich
Copy link
Contributor Author

@reinrich reinrich commented Aug 4, 2021

Can use curl to watch this?

I guess you could...

Loading

@reinrich
Copy link
Contributor Author

@reinrich reinrich commented Aug 4, 2021

The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout JDK-8271721-split-TestMixedGCLiveThreshold
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

Hi @edvbld,

this is my first dependent pr. So far it went well but now I've got issues with the procedure above.

First: ist there a -b missing in git checkout JDK-8271721-split-TestMixedGCLiveThreshold?

I've executed all the steps above (with -b in the first command) but I still see a commit from #4968 in this pr's commits.

Besides that I don't quite understand how it would help to create that new branch and push it to my personal fork.

I expected merging master into this pr's branch (https://github.com/reinrich/jdk/tree/8271722__TESTBUG__gc_g1_TestMixedGCLiveThreshold_java_can_fail_if_G1_Full_GC_uses__gt_1_workers) would help but that didn't.

Can you help to get rid of the 'start' commit by @tstuefe in this pr's commits?

Cheers, Richard.

Loading

@reinrich
Copy link
Contributor Author

@reinrich reinrich commented Aug 4, 2021

The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout JDK-8271721-split-TestMixedGCLiveThreshold
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

Hi @edvbld,

this is my first dependent pr. So far it went well but now I've got issues with the procedure above.

First: ist there a -b missing in git checkout JDK-8271721-split-TestMixedGCLiveThreshold?

I've executed all the steps above (with -b in the first command) but I still see a commit from #4968 in this pr's commits.

Besides that I don't quite understand how it would help to create that new branch and push it to my personal fork.

I expected merging master into this pr's branch (https://github.com/reinrich/jdk/tree/8271722__TESTBUG__gc_g1_TestMixedGCLiveThreshold_java_can_fail_if_G1_Full_GC_uses__gt_1_workers) would help but that didn't.

Can you help to get rid of the 'start' commit by @tstuefe in this pr's commits?

Cheers, Richard.

Hi @kevinrushforth and @erikj79,

@edvbld seems to be less engaged with skara recently. Maybe you can help me out with the issues described above?

Thanks, Richard.

Loading

@reinrich
Copy link
Contributor Author

@reinrich reinrich commented Aug 5, 2021

Thanks for the reviews Albert and Thomas!

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 5, 2021

Going to push as commit 4abe531.
Since your change was applied there have been 25 commits pushed to the master branch:

  • ea9a595: 8270058: Use Objects.check{Index,FromIndexSize} for java.desktop
  • 64d18d4: 4819544: SwingSet2 JTable Demo throws NullPointerException
  • 6c8441f: 8271878: UnProblemList jdk/jfr/event/gc/detailed/TestEvacuationFailedEvent.java in JDK18
  • 7728423: 8271895: UnProblemList javax/swing/JComponent/7154030/bug7154030.java in JDK18
  • cd6b54e: Merge
  • cebcc07: 8271894: ProblemList javax/swing/JComponent/7154030/bug7154030.java in JDK17
  • 5f547e8: 8271877: ProblemList jdk/jfr/event/gc/detailed/TestEvacuationFailedEvent.java in JDK17
  • 181483b: 8271064: ZGC several jvm08 perf regressions after JDK-8268372
  • a007cb1: 8271863: ProblemList serviceability/sa/TestJmapCore.java on linux-x64 with ZGC
  • d62fbea: 8271898: disable os.release_multi_mappings_vm on macOS-X64
  • ... and 15 more: https://git.openjdk.java.net/jdk/compare/977b8c4e16b02421de8bf78dc60a3866ce25fc1f...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Aug 5, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 5, 2021

@reinrich Pushed as commit 4abe531.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants