Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265057: G1: Investigate removal of maintenance of two BOT thresholds #4972

Closed
wants to merge 6 commits into from

Conversation

walulyai
Copy link
Member

@walulyai walulyai commented Aug 3, 2021

Hi all,

Please review this change to remove _next_offset_index and maintain only one threshold _next_offset_threshold a direct pointer to the BOT entry in the BOT. We derive the next_offset_index from from _next_offset_threshold where required. Performance tests do not show any regression as a result of this change.

Testing: Tier 1-5


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8265057: G1: Investigate removal of maintenance of two BOT thresholds

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4972/head:pull/4972
$ git checkout pull/4972

Update a local copy of the PR:
$ git checkout pull/4972
$ git pull https://git.openjdk.java.net/jdk pull/4972/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4972

View PR using the GUI difftool:
$ git pr show -t 4972

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4972.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 3, 2021

👋 Welcome back iwalulya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Aug 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 3, 2021

@walulyai The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Aug 3, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 3, 2021

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Lgtm apart from the suggested fixes to some comments.

@@ -309,7 +308,6 @@ void G1BlockOffsetTablePart::alloc_block_work(HeapWord** threshold_, size_t* ind

// index_ and threshold_ updated here.
Copy link
Contributor

@tschatzl tschatzl Aug 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment about _index. Maybe just "Finally update threshold_." at the end, but simply removing the comment seems as fine.

// For efficiency, do copy-in/copy-out.
HeapWord* threshold = *threshold_;
size_t index = *index_;
size_t index = _bot->index_for_raw(threshold);
Copy link
Contributor

@tschatzl tschatzl Aug 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superfluous spaces but maybe keep it for consistency in this method/file.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 3, 2021

@walulyai This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265057: G1: Investigate removal of maintenance of two BOT thresholds

Reviewed-by: ayang, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • bdb50ca: 8270347: ZGC: Adopt release-acquire ordering for forwarding table access

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 3, 2021
@walulyai
Copy link
Member Author

@walulyai walulyai commented Aug 4, 2021

Thanks @albertnetymk and @tschatzl for the reviews!

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Aug 4, 2021

Going to push as commit 0a27f26.
Since your change was applied there have been 24 commits pushed to the master branch:

  • eec64f5: 8256844: Make NMT late-initializable
  • 4df1bc4: 6350025: API documentation for JOptionPane using deprecated methods.
  • efcdcc7: 8270893: IndexOutOfBoundsException while reading large TIFF file
  • 977b8c4: 8271836: runtime/ErrorHandling/ClassPathEnvVar.java fails with release VMs
  • 04134fc: 8264543: Cross modify fence optimization for x86
  • 9e76909: 8271824: mark hotspot runtime/CompressedOops tests which ignore external VM flags
  • e49b7d9: 8271828: mark hotspot runtime/classFileParserBug tests which ignore external VM flags
  • 68f7847: 8271825: mark hotspot runtime/LoadClass tests which ignore external VM flags
  • 3d40cac: 8271821: mark hotspot runtime/MinimalVM tests which ignore external VM flags
  • 33ec3a4: 8271744: mark hotspot runtime/getSysPackage tests which ignore external VM flags
  • ... and 14 more: https://git.openjdk.java.net/jdk/compare/b217a6ca0f920eddc1d4596ce8c6445423f1d15d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 4, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 4, 2021

@walulyai Pushed as commit 0a27f26.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated
3 participants