Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269037: jsig/Testjsig.java doesn't have to be restricted to linux only #4975

Closed
wants to merge 1 commit into from

Conversation

iignatev
Copy link
Member

@iignatev iignatev commented Aug 3, 2021

Hi all,

could you please review this small patch that enables runtime/jsig/Testjsig.java test and compilation of its native library on all platforms but windows?
from JBS:

runtime/jsig/Testjsig.java test currently @requires (os.family == "linux") and test/hotspot/jtreg/runtime/jsig/libTestJNI.c compilation is restricted to linux only, however there seems to be nothing in the test code that prevents it from execution on a system that supports POSIX.

testing: runtime/jsig/Testjsig.java on {linux,windows,macosx}-x64

Thanks,
-- Igor


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8269037: jsig/Testjsig.java doesn't have to be restricted to linux only

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4975/head:pull/4975
$ git checkout pull/4975

Update a local copy of the PR:
$ git checkout pull/4975
$ git pull https://git.openjdk.java.net/jdk pull/4975/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4975

View PR using the GUI difftool:
$ git pr show -t 4975

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4975.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 3, 2021

👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8269037 8269037: jsig/Testjsig.java doesn't have to be restricted to linux only Aug 3, 2021
@openjdk openjdk bot added the rfr label Aug 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 3, 2021

@iignatev The following labels will be automatically applied to this pull request:

  • build
  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-runtime build labels Aug 3, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 3, 2021

Webrevs

Copy link
Member

@mseledts mseledts left a comment

Changes look good to me.

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Looks good.

Thanks,
David

@openjdk
Copy link

@openjdk openjdk bot commented Aug 4, 2021

@iignatev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269037: jsig/Testjsig.java doesn't have to be restricted to linux only

Reviewed-by: mseledtsov, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 7e518f4: 8269934: RunThese24H.java failed with EXCEPTION_ACCESS_VIOLATION in java_lang_Thread::get_thread_status
  • 659498a: 8271829: mark hotspot runtime/Throwable tests which ignore external VM flags
  • d3b40cb: 8271826: mark hotspot runtime/condy tests which ignore external VM flags
  • 3435d29: 8271003: hs_err improvement: handle CLASSPATH env setting longer than O_BUFLEN
  • 43a6ba9: 8271726: JFR: should use equal() to check event fields in tests
  • a840870: 8271616: oddPart in MutableBigInteger::mutableModInverse contains info on final result

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 4, 2021
@iignatev
Copy link
Member Author

@iignatev iignatev commented Aug 4, 2021

David, Misha,

thank you for your reviews.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Aug 4, 2021

Going to push as commit 34ba70a.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 7e518f4: 8269934: RunThese24H.java failed with EXCEPTION_ACCESS_VIOLATION in java_lang_Thread::get_thread_status
  • 659498a: 8271829: mark hotspot runtime/Throwable tests which ignore external VM flags
  • d3b40cb: 8271826: mark hotspot runtime/condy tests which ignore external VM flags
  • 3435d29: 8271003: hs_err improvement: handle CLASSPATH env setting longer than O_BUFLEN
  • 43a6ba9: 8271726: JFR: should use equal() to check event fields in tests
  • a840870: 8271616: oddPart in MutableBigInteger::mutableModInverse contains info on final result

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 4, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 4, 2021

@iignatev Pushed as commit 34ba70a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@iignatev iignatev deleted the 8269037 branch Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build hotspot-runtime integrated
3 participants