-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8271821: mark hotspot runtime/MinimalVM tests which ignore external VM flags #4979
Conversation
👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Thanks,
David
@iignatev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 11 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Thanks, David. |
@iignatev Unknown command |
/integrate |
Going to push as commit 3d40cac.
Your commit was automatically rebased without conflicts. |
Hi all,
could you please review this patch that adds
@requires vm.flagless
toruntime/MinimalVM/
tests as they ignore external VM flags?Thanks,
-- Igor
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4979/head:pull/4979
$ git checkout pull/4979
Update a local copy of the PR:
$ git checkout pull/4979
$ git pull https://git.openjdk.java.net/jdk pull/4979/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4979
View PR using the GUI difftool:
$ git pr show -t 4979
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4979.diff