8271821: mark hotspot runtime/MinimalVM tests which ignore external VM flags

[iignatev]

Hi all,

could you please review this patch that adds @requires vm.flagless to runtime/MinimalVM/ tests as they ignore external VM flags?

Thanks,
-- Igor

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8271821: mark hotspot runtime/MinimalVM tests which ignore external VM flags

Reviewers

• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4979/head:pull/4979
$ git checkout pull/4979

Update a local copy of the PR:
$ git checkout pull/4979
$ git pull https://git.openjdk.java.net/jdk pull/4979/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4979

View PR using the GUI difftool:
$ git pr show -t 4979

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4979.diff

[bridgekeeper]

👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iignatev The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (8a1021d9)

[dholmes-ora]

Looks good.

Thanks,
David

[openjdk]

@iignatev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271821: mark hotspot runtime/MinimalVM tests which ignore external VM flags

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• 33ec3a4: 8271744: mark hotspot runtime/getSysPackage tests which ignore external VM flags
• b48f31d: 8271743: mark hotspot runtime/jni tests which ignore external VM flags
• 66c653c: 8271721: Split gc/g1/TestMixedGCLiveThreshold into separate tests
• 68dd828: 8271224: runtime/EnclosingMethodAttr/EnclMethodAttr.java doesn't check exit code
• 34ba70a: 8269037: jsig/Testjsig.java doesn't have to be restricted to linux only
• 7e518f4: 8269934: RunThese24H.java failed with EXCEPTION_ACCESS_VIOLATION in java_lang_Thread::get_thread_status
• 659498a: 8271829: mark hotspot runtime/Throwable tests which ignore external VM flags
• d3b40cb: 8271826: mark hotspot runtime/condy tests which ignore external VM flags
• 3435d29: 8271003: hs_err improvement: handle CLASSPATH env setting longer than O_BUFLEN
• 43a6ba9: 8271726: JFR: should use equal() to check event fields in tests
• ... and 1 more: https://git.openjdk.java.net/jdk/compare/0199b03eb3bd9ffe79b5193ff1792144b5c488f1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[iignatev]

Thanks, David.

[openjdk]

@iignatev Unknown command intregrate - for a list of valid commands use /help.

[iignatev]

/integrate

[openjdk]

Going to push as commit 3d40cac.
Since your change was applied there have been 11 commits pushed to the master branch:

• 33ec3a4: 8271744: mark hotspot runtime/getSysPackage tests which ignore external VM flags
• b48f31d: 8271743: mark hotspot runtime/jni tests which ignore external VM flags
• 66c653c: 8271721: Split gc/g1/TestMixedGCLiveThreshold into separate tests
• 68dd828: 8271224: runtime/EnclosingMethodAttr/EnclMethodAttr.java doesn't check exit code
• 34ba70a: 8269037: jsig/Testjsig.java doesn't have to be restricted to linux only
• 7e518f4: 8269934: RunThese24H.java failed with EXCEPTION_ACCESS_VIOLATION in java_lang_Thread::get_thread_status
• 659498a: 8271829: mark hotspot runtime/Throwable tests which ignore external VM flags
• d3b40cb: 8271826: mark hotspot runtime/condy tests which ignore external VM flags
• 3435d29: 8271003: hs_err improvement: handle CLASSPATH env setting longer than O_BUFLEN
• 43a6ba9: 8271726: JFR: should use equal() to check event fields in tests
• ... and 1 more: https://git.openjdk.java.net/jdk/compare/0199b03eb3bd9ffe79b5193ff1792144b5c488f1...master

Your commit was automatically rebased without conflicts.

[openjdk]

@iignatev Pushed as commit 3d40cac.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.