Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271836: runtime/ErrorHandling/ClassPathEnvVar.java fails with release VMs #4987

Closed
wants to merge 1 commit into from

Conversation

DamonFool
Copy link
Member

@DamonFool DamonFool commented Aug 4, 2021

Hi all,

runtime/ErrorHandling/ClassPathEnvVar.java fails with release VMs.
The fix is only run the test with debug VMs.

Thanks.
Best regards,
Jie


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8271836: runtime/ErrorHandling/ClassPathEnvVar.java fails with release VMs

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4987/head:pull/4987
$ git checkout pull/4987

Update a local copy of the PR:
$ git checkout pull/4987
$ git pull https://git.openjdk.java.net/jdk pull/4987/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4987

View PR using the GUI difftool:
$ git pr show -t 4987

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4987.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 4, 2021

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Aug 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 4, 2021

@DamonFool The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime label Aug 4, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 4, 2021

Webrevs

tstuefe
tstuefe approved these changes Aug 4, 2021
Copy link
Member

@tstuefe tstuefe left a comment

Oh right, ErrorHandlerTest is only available in debug builds.

Fix is good and trivial.

..Thomas

@openjdk
Copy link

@openjdk openjdk bot commented Aug 4, 2021

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271836: runtime/ErrorHandling/ClassPathEnvVar.java fails with release VMs

Reviewed-by: stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 4, 2021
@DamonFool
Copy link
Member Author

@DamonFool DamonFool commented Aug 4, 2021

Oh right, ErrorHandlerTest is only available in debug builds.

Fix is good and trivial.

..Thomas

Thanks Thomas.
/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Aug 4, 2021

Going to push as commit 977b8c4.

@openjdk openjdk bot closed this Aug 4, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 4, 2021

@DamonFool Pushed as commit 977b8c4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@DamonFool DamonFool deleted the JDK-8271836 branch Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime integrated
2 participants