New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8271840: Add simple Integer.toString microbenchmarks #4988
Conversation
|
@cl4es This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 22 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
Thanks! /integrate |
Going to push as commit 55bd52a.
Your commit was automatically rebased without conflicts. |
This adds Integer.toString microbenchmarks, roughly similar to the Long.toString microbenchmarks (toStringSmall should use an equivalent data set). This is useful for comparison purposes and completeness.
Also tuned existing benchmarks to harmonize setup, reduce runtime without significantly harming reliability of results, and remove the explicit Threads.MAX from Longs
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4988/head:pull/4988
$ git checkout pull/4988
Update a local copy of the PR:
$ git checkout pull/4988
$ git pull https://git.openjdk.java.net/jdk pull/4988/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4988
View PR using the GUI difftool:
$ git pr show -t 4988
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4988.diff