Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271840: Add simple Integer.toString microbenchmarks #4988

Closed
wants to merge 1 commit into from

Conversation

cl4es
Copy link
Member

@cl4es cl4es commented Aug 4, 2021

This adds Integer.toString microbenchmarks, roughly similar to the Long.toString microbenchmarks (toStringSmall should use an equivalent data set). This is useful for comparison purposes and completeness.

Also tuned existing benchmarks to harmonize setup, reduce runtime without significantly harming reliability of results, and remove the explicit Threads.MAX from Longs


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8271840: Add simple Integer.toString microbenchmarks

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4988/head:pull/4988
$ git checkout pull/4988

Update a local copy of the PR:
$ git checkout pull/4988
$ git pull https://git.openjdk.java.net/jdk pull/4988/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4988

View PR using the GUI difftool:
$ git pr show -t 4988

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4988.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 4, 2021

👋 Welcome back redestad! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Aug 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 4, 2021

@cl4es The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Aug 4, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 4, 2021

Webrevs

Copy link
Contributor

@shipilev shipilev left a comment

Looks fine.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 4, 2021

@cl4es This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271840: Add simple Integer.toString microbenchmarks

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

  • 977b8c4: 8271836: runtime/ErrorHandling/ClassPathEnvVar.java fails with release VMs
  • 04134fc: 8264543: Cross modify fence optimization for x86
  • 9e76909: 8271824: mark hotspot runtime/CompressedOops tests which ignore external VM flags
  • e49b7d9: 8271828: mark hotspot runtime/classFileParserBug tests which ignore external VM flags
  • 68f7847: 8271825: mark hotspot runtime/LoadClass tests which ignore external VM flags
  • 3d40cac: 8271821: mark hotspot runtime/MinimalVM tests which ignore external VM flags
  • 33ec3a4: 8271744: mark hotspot runtime/getSysPackage tests which ignore external VM flags
  • b48f31d: 8271743: mark hotspot runtime/jni tests which ignore external VM flags
  • 66c653c: 8271721: Split gc/g1/TestMixedGCLiveThreshold into separate tests
  • 68dd828: 8271224: runtime/EnclosingMethodAttr/EnclMethodAttr.java doesn't check exit code
  • ... and 12 more: https://git.openjdk.java.net/jdk/compare/c8add223a10030e40ccef42e081fd0d8f00e0593...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 4, 2021
@cl4es
Copy link
Member Author

@cl4es cl4es commented Aug 5, 2021

Looks fine.

Thanks!

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Aug 5, 2021

Going to push as commit 55bd52a.
Since your change was applied there have been 50 commits pushed to the master branch:

  • 18dd4d4: 8271121: ZGC: stack overflow (segv) when -Xlog:gc+start=debug
  • 685fc3c: 8270903: sun.net.httpserver.HttpConnection: Improve toString
  • 4abe531: 8271722: [TESTBUG] gc/g1/TestMixedGCLiveThreshold.java can fail if G1 Full GC uses >1 workers
  • ea9a595: 8270058: Use Objects.check{Index,FromIndexSize} for java.desktop
  • 64d18d4: 4819544: SwingSet2 JTable Demo throws NullPointerException
  • 6c8441f: 8271878: UnProblemList jdk/jfr/event/gc/detailed/TestEvacuationFailedEvent.java in JDK18
  • 7728423: 8271895: UnProblemList javax/swing/JComponent/7154030/bug7154030.java in JDK18
  • cd6b54e: Merge
  • cebcc07: 8271894: ProblemList javax/swing/JComponent/7154030/bug7154030.java in JDK17
  • 5f547e8: 8271877: ProblemList jdk/jfr/event/gc/detailed/TestEvacuationFailedEvent.java in JDK17
  • ... and 40 more: https://git.openjdk.java.net/jdk/compare/c8add223a10030e40ccef42e081fd0d8f00e0593...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 5, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 5, 2021

@cl4es Pushed as commit 55bd52a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs integrated
2 participants