Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271855: [TESTBUG] Wrong weakCompareAndSet assumption in UnsafeIntrinsicsTest #4992

Closed

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Aug 4, 2021

We need a fix for test failures due to wrong assumption. (See JBS issue for details.) I suggest to give weakCompareAndSet several chances.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8271855: [TESTBUG] Wrong weakCompareAndSet assumption in UnsafeIntrinsicsTest

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4992/head:pull/4992
$ git checkout pull/4992

Update a local copy of the PR:
$ git checkout pull/4992
$ git pull https://git.openjdk.java.net/jdk pull/4992/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4992

View PR using the GUI difftool:
$ git pr show -t 4992

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4992.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 4, 2021

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 4, 2021

@TheRealMDoerr The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler label Aug 4, 2021
@TheRealMDoerr
Copy link
Contributor Author

@TheRealMDoerr TheRealMDoerr commented Aug 4, 2021

/label add gc

@openjdk
Copy link

@openjdk openjdk bot commented Aug 4, 2021

@TheRealMDoerr The label gc is not a valid label. These labels are valid:

  • serviceability
  • hotspot
  • sound
  • hotspot-compiler
  • ide-support
  • kulla
  • i18n
  • shenandoah
  • jdk
  • javadoc
  • security
  • 2d
  • swing
  • hotspot-runtime
  • jmx
  • nio
  • build
  • beans
  • core-libs
  • compiler
  • net
  • hotspot-gc
  • hotspot-jfr
  • awt

@TheRealMDoerr
Copy link
Contributor Author

@TheRealMDoerr TheRealMDoerr commented Aug 4, 2021

/label add hotspot-gc

@openjdk openjdk bot added the hotspot-gc label Aug 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 4, 2021

@TheRealMDoerr
The hotspot-gc label was successfully added.

@TheRealMDoerr TheRealMDoerr changed the title 8271855: [testbug] Wrong weakCompareAndSet assumption in UnsafeIntrinsicsTest 8271855: [TESTBUG] Wrong weakCompareAndSet assumption in UnsafeIntrinsicsTest Aug 4, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 1, 2021

@TheRealMDoerr This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@TheRealMDoerr TheRealMDoerr force-pushed the 8271855_UnsafeIntrinsicsTest branch from a781513 to 34b40cd Compare Sep 28, 2021
@TheRealMDoerr TheRealMDoerr marked this pull request as ready for review Sep 28, 2021
@openjdk openjdk bot added the rfr label Sep 28, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 28, 2021

Webrevs

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 28, 2021

Hi Martin,
why do you think 4 iterations are what you need?
I think you should add 8271855 to @bug.
Best regards,
Goetz

@TheRealMDoerr
Copy link
Contributor Author

@TheRealMDoerr TheRealMDoerr commented Sep 28, 2021

The test should usually pass within 2 iterations. It could happen that 2 different reasons make it fail (e.g. GC touches the cache line, OS takes the process from the CPU, interrupt occurs, ...). So, I think 2 iterations should usually work, 3 ones should be enough to prevent very sporadic failures in the future.

GoeLin
GoeLin approved these changes Sep 28, 2021
Copy link
Member

@GoeLin GoeLin left a comment

LGTM

@openjdk
Copy link

@openjdk openjdk bot commented Sep 28, 2021

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271855: [TESTBUG] Wrong weakCompareAndSet assumption in UnsafeIntrinsicsTest

Reviewed-by: goetz, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

  • 756d22c: 8274130: C2: MulNode::Ideal chained transformations may act on wrong nodes
  • 5b0c9cc: 8274172: Convert JavadocTester to use NIO
  • 2657bcb: 8274136: -XX:+ExitOnOutOfMemoryError calls exit while threads are running
  • 53b25bc: 8273459: Update code segment alignment to 64 bytes
  • 1a29b1e: 8274016: Replace 'for' cycles with iterator with enhanced-for in java.desktop
  • d8a278f: 8274396: Suppress more warnings on non-serializable non-transient instance fields in client libs
  • e49e5b5: 8273972: Multi-core choke point in CMM engine (LCMSTransform.doTransform)
  • 2072bc7: 8274391: Suppress more warnings on non-serializable non-transient instance fields in java.util.concurrent
  • 6a477bd: 8274415: Suppress warnings on non-serializable non-transient instance fields in java.xml
  • 67e52a3: 8273634: [TEST_BUG] Improve javax/swing/text/ParagraphView/6364882/bug6364882.java
  • ... and 8 more: https://git.openjdk.java.net/jdk/compare/6a573b888d4d3322b9165562f85e1b7b781a5ff1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 28, 2021
Copy link
Member

@TobiHartmann TobiHartmann left a comment

Looks good to me.

@TheRealMDoerr
Copy link
Contributor Author

@TheRealMDoerr TheRealMDoerr commented Sep 29, 2021

Thanks for the reviews!
/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 29, 2021

Going to push as commit c4d1157.
Since your change was applied there have been 18 commits pushed to the master branch:

  • 756d22c: 8274130: C2: MulNode::Ideal chained transformations may act on wrong nodes
  • 5b0c9cc: 8274172: Convert JavadocTester to use NIO
  • 2657bcb: 8274136: -XX:+ExitOnOutOfMemoryError calls exit while threads are running
  • 53b25bc: 8273459: Update code segment alignment to 64 bytes
  • 1a29b1e: 8274016: Replace 'for' cycles with iterator with enhanced-for in java.desktop
  • d8a278f: 8274396: Suppress more warnings on non-serializable non-transient instance fields in client libs
  • e49e5b5: 8273972: Multi-core choke point in CMM engine (LCMSTransform.doTransform)
  • 2072bc7: 8274391: Suppress more warnings on non-serializable non-transient instance fields in java.util.concurrent
  • 6a477bd: 8274415: Suppress warnings on non-serializable non-transient instance fields in java.xml
  • 67e52a3: 8273634: [TEST_BUG] Improve javax/swing/text/ParagraphView/6364882/bug6364882.java
  • ... and 8 more: https://git.openjdk.java.net/jdk/compare/6a573b888d4d3322b9165562f85e1b7b781a5ff1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 29, 2021
@openjdk openjdk bot added integrated and removed ready labels Sep 29, 2021
@openjdk openjdk bot removed the rfr label Sep 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 29, 2021

@TheRealMDoerr Pushed as commit c4d1157.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the 8271855_UnsafeIntrinsicsTest branch Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-gc integrated
3 participants