Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271863: ProblemList serviceability/sa/TestJmapCore.java on linux-x64 with ZGC #4994

Closed
wants to merge 1 commit into from

Conversation

YaSuenag
Copy link
Member

@YaSuenag YaSuenag commented Aug 4, 2021

We saw some failures of TestJmapCore.java, and we need more time to fix it. So we should add it to ProblemList-zgc.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8271863: ProblemList serviceability/sa/TestJmapCore.java on linux-x64 with ZGC

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4994/head:pull/4994
$ git checkout pull/4994

Update a local copy of the PR:
$ git checkout pull/4994
$ git pull https://git.openjdk.java.net/jdk pull/4994/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4994

View PR using the GUI difftool:
$ git pr show -t 4994

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4994.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 4, 2021

👋 Welcome back ysuenaga! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@YaSuenag
Copy link
Member Author

@YaSuenag YaSuenag commented Aug 4, 2021

/label add serviceability

@openjdk openjdk bot added rfr serviceability labels Aug 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 4, 2021

@YaSuenag
The serviceability label was successfully added.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 4, 2021

Webrevs

Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Thumbs up. This is a trivial fix.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 4, 2021

@YaSuenag This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271863: ProblemList serviceability/sa/TestJmapCore.java on linux-x64 with ZGC

Reviewed-by: dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 452f7d7: 8271217: Fix race between G1PeriodicGCTask checks and GC request

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 4, 2021
@YaSuenag
Copy link
Member Author

@YaSuenag YaSuenag commented Aug 4, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Aug 4, 2021

Going to push as commit a007cb1.
Since your change was applied there have been 11 commits pushed to the master branch:

  • d62fbea: 8271898: disable os.release_multi_mappings_vm on macOS-X64
  • 359c708: 8271893: mark hotspot runtime/PerfMemDestroy/PerfMemDestroy.java test as ignoring external VM flags
  • a3b0143: 8271887: mark hotspot runtime/CDSCompressedKPtrs tests which ignore external VM flags
  • 6c17e6d: 8271891: mark hotspot runtime/Safepoint tests which ignore external VM flags
  • ff7431e: 8271886: mark hotspot runtime/InvocationTests tests which ignore external VM flags
  • cdf3d55: 8271890: mark hotspot runtime/Dictionary tests which ignore external VM flags
  • 91bbe2f: 8271888: build error after JDK-8271599
  • 6b55ef3: 8271456: Avoid looking up standard charsets in "java.desktop" module
  • 392fcc9: 8271589: fatal error with variable shift count integer rotate operation.
  • 9f1edaf: 8271599: Javadoc of floorDiv() and floorMod() families is inaccurate in some places
  • ... and 1 more: https://git.openjdk.java.net/jdk/compare/221e4b9c61cd1c9c3f4c037589ba639541532910...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 4, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 4, 2021

@YaSuenag Pushed as commit a007cb1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@YaSuenag YaSuenag deleted the JDK-8271863 branch Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated serviceability
2 participants