8271891: mark hotspot runtime/Safepoint tests which ignore external VM flags

[iignatev]

Hi all,

please review this small patch that @requires vm.flagless to runtime/Safepoint tests.

Thanks,
-- Igor

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8271891: mark hotspot runtime/Safepoint tests which ignore external VM flags

Reviewers

• Coleen Phillimore (@coleenp - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5000/head:pull/5000
$ git checkout pull/5000

Update a local copy of the PR:
$ git checkout pull/5000
$ git pull https://git.openjdk.java.net/jdk pull/5000/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5000

View PR using the GUI difftool:
$ git pr show -t 5000

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5000.diff

[bridgekeeper]

👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iignatev The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (c0371ccb)

[coleenp]

Ok, plus trivial.

[coleenp]

So it's essentially the driver tests - ie tests that call process builder to run the test that need this?

[iignatev]

there are two kind of tests that can/should have vm.flagless:

• 1st, the driver tests that don't pass external flags to a child JVM, in that case, it's useless to run the test w/ any external flags as you won't get any signal and just waste time
• 2nd, tests that aren't designed to be run w/ external flags, tests that highly depend on JVM configuration to the extent that the majority of configurations make such tests inapplicable, e.g. jfr tests.

all the tests which I'm marking in 8246498 sub-tasks are of the first kind.

[openjdk]

@iignatev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271891: mark hotspot runtime/Safepoint tests which ignore external VM flags

Reviewed-by: coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

• 91bbe2f: 8271888: build error after JDK-8271599
• 6b55ef3: 8271456: Avoid looking up standard charsets in "java.desktop" module
• 392fcc9: 8271589: fatal error with variable shift count integer rotate operation.
• 9f1edaf: 8271599: Javadoc of floorDiv() and floorMod() families is inaccurate in some places
• 452f7d7: 8271217: Fix race between G1PeriodicGCTask checks and GC request
• 221e4b9: 8270797: ShortECDSA.java test is not complete
• 0a27f26: 8265057: G1: Investigate removal of maintenance of two BOT thresholds
• eec64f5: 8256844: Make NMT late-initializable
• 4df1bc4: 6350025: API documentation for JOptionPane using deprecated methods.
• efcdcc7: 8270893: IndexOutOfBoundsException while reading large TIFF file
• ... and 17 more: https://git.openjdk.java.net/jdk/compare/0199b03eb3bd9ffe79b5193ff1792144b5c488f1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[iignatev]

Thank you for your review, Coleen.

/integrate

[openjdk]

Going to push as commit 6c17e6d.
Since your change was applied there have been 29 commits pushed to the master branch:

• ff7431e: 8271886: mark hotspot runtime/InvocationTests tests which ignore external VM flags
• cdf3d55: 8271890: mark hotspot runtime/Dictionary tests which ignore external VM flags
• 91bbe2f: 8271888: build error after JDK-8271599
• 6b55ef3: 8271456: Avoid looking up standard charsets in "java.desktop" module
• 392fcc9: 8271589: fatal error with variable shift count integer rotate operation.
• 9f1edaf: 8271599: Javadoc of floorDiv() and floorMod() families is inaccurate in some places
• 452f7d7: 8271217: Fix race between G1PeriodicGCTask checks and GC request
• 221e4b9: 8270797: ShortECDSA.java test is not complete
• 0a27f26: 8265057: G1: Investigate removal of maintenance of two BOT thresholds
• eec64f5: 8256844: Make NMT late-initializable
• ... and 19 more: https://git.openjdk.java.net/jdk/compare/0199b03eb3bd9ffe79b5193ff1792144b5c488f1...master

Your commit was automatically rebased without conflicts.

[openjdk]

@iignatev Pushed as commit 6c17e6d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.