-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8271891: mark hotspot runtime/Safepoint tests which ignore external VM flags #5000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, plus trivial.
@@ -28,6 +28,7 @@ | |||
* @test TestAbortOnVMOperationTimeout | |||
* @bug 8181143 8269523 | |||
* @summary Check abort on VM timeout is working | |||
* @requires vm.flagless |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it's essentially the driver tests - ie tests that call process builder to run the test that need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are two kind of tests that can/should have vm.flagless
:
- 1st, the driver tests that don't pass external flags to a child JVM, in that case, it's useless to run the test w/ any external flags as you won't get any signal and just waste time
- 2nd, tests that aren't designed to be run w/ external flags, tests that highly depend on JVM configuration to the extent that the majority of configurations make such tests inapplicable, e.g. jfr tests.
all the tests which I'm marking in 8246498 sub-tasks are of the first kind.
@iignatev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 27 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Thank you for your review, Coleen. /integrate |
Going to push as commit 6c17e6d.
Your commit was automatically rebased without conflicts. |
Hi all,
please review this small patch that
@requires vm.flagless
toruntime/Safepoint
tests.Thanks,
-- Igor
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5000/head:pull/5000
$ git checkout pull/5000
Update a local copy of the PR:
$ git checkout pull/5000
$ git pull https://git.openjdk.java.net/jdk pull/5000/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5000
View PR using the GUI difftool:
$ git pr show -t 5000
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5000.diff