8271898: disable os.release_multi_mappings_vm on macOS-X64

[dcubed-ojdk]

A trivial fix to disable os.release_multi_mappings_vm on macOS-X64.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8271898: disable os.release_multi_mappings_vm on macOS-X64

Reviewers

• Kim Barrett (@kimbarrett - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5006/head:pull/5006
$ git checkout pull/5006

Update a local copy of the PR:
$ git checkout pull/5006
$ git pull https://git.openjdk.java.net/jdk pull/5006/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5006

View PR using the GUI difftool:
$ git pr show -t 5006

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5006.diff

[dcubed-ojdk]

/label add hotspot-runtime
/label add hotspot-gc

[bridgekeeper]

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dcubed-ojdk
The hotspot-runtime label was successfully added.

[openjdk]

@dcubed-ojdk
The hotspot-gc label was successfully added.

[mlbridge]

Webrevs

• 00: Full (1f7234cc)

[kimbarrett]

Looks "good" (actually kind of horrible, but...)

[openjdk]

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271898: disable os.release_multi_mappings_vm on macOS-X64

Reviewed-by: kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• 359c708: 8271893: mark hotspot runtime/PerfMemDestroy/PerfMemDestroy.java test as ignoring external VM flags
• a3b0143: 8271887: mark hotspot runtime/CDSCompressedKPtrs tests which ignore external VM flags
• 6c17e6d: 8271891: mark hotspot runtime/Safepoint tests which ignore external VM flags
• ff7431e: 8271886: mark hotspot runtime/InvocationTests tests which ignore external VM flags
• cdf3d55: 8271890: mark hotspot runtime/Dictionary tests which ignore external VM flags

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dcubed-ojdk]

@kimbarrett - Thanks for the fast review. Yes, it is kind of horrible, but it's what we have for gtest...

[dcubed-ojdk]

/integrate

[kimbarrett]

Oh, and yes, trivial.

[openjdk]

Going to push as commit d62fbea.
Since your change was applied there have been 5 commits pushed to the master branch:

• 359c708: 8271893: mark hotspot runtime/PerfMemDestroy/PerfMemDestroy.java test as ignoring external VM flags
• a3b0143: 8271887: mark hotspot runtime/CDSCompressedKPtrs tests which ignore external VM flags
• 6c17e6d: 8271891: mark hotspot runtime/Safepoint tests which ignore external VM flags
• ff7431e: 8271886: mark hotspot runtime/InvocationTests tests which ignore external VM flags
• cdf3d55: 8271890: mark hotspot runtime/Dictionary tests which ignore external VM flags

Your commit was automatically rebased without conflicts.

[openjdk]

@dcubed-ojdk Pushed as commit d62fbea.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[dcubed-ojdk]

And thanks for the confirmation that it is trivial. Since this is just a replay of:

JDK-8267339 Temporarily disable os.release_multi_mappings_vm on macOS x64

I wasn't too worried about it. :-)

[tstuefe]

Must have been an error when merging the original JDK-8267339 into JDK-8256844. Thanks, @dcubed-ojdk for taking care of this.