8140442: Add getOutermostTypeElement to javax.lang.model utility class #5007

jddarcy · 2021-08-04T22:41:22Z

Please review this change to add a getOutermostTypeElement method to javax.lang.model.Elements along with the corresponding CSR https://bugs.openjdk.java.net/browse/JDK-8271903.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8140442: Add getOutermostTypeElement to javax.lang.model utility class

Reviewers

Jan Lahoda (@lahodaj - Reviewer) ⚠️ Review applies to bc1de3f

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5007/head:pull/5007
$ git checkout pull/5007

Update a local copy of the PR:
$ git checkout pull/5007
$ git pull https://git.openjdk.java.net/jdk pull/5007/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5007

View PR using the GUI difftool:
$ git pr show -t 5007

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5007.diff

bridgekeeper · 2021-08-04T22:42:37Z

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2021-08-04T22:44:45Z

@jddarcy The following label will be automatically applied to this pull request:

compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

jddarcy · 2021-08-04T22:46:55Z

/csr needed

openjdk · 2021-08-04T22:47:05Z

@jddarcy this pull request will not be integrated until the CSR request JDK-8271903 for issue JDK-8140442 has been approved.

mlbridge · 2021-08-04T22:51:45Z

Webrevs

lahodaj

To me, looks good, with some nits inlined.

lahodaj · 2021-08-10T12:55:52Z

src/java.compiler/share/classes/javax/lang/model/util/Elements.java

+            // This implementation is susceptible to infinite loops
+            // for misbehaving element implementations.
+            while (true) {
+                // Conceptual instanceof TypeElment check. If the


Nit:

Suggested change

// Conceptual instanceof TypeElment check. If the

// Conceptual instanceof TypeElement check. If the

Nits fixed; thanks for the review.

lahodaj · 2021-08-10T12:57:00Z

test/langtools/tools/javac/processing/model/util/elements/TestOutermostTypeElement.java

+
+        @Override
+        public Void scan(Element e, Elements elts) {
+            // System.out.println(e.getSimpleName() + " " + e.getKind());


Nit:

Suggested change

// System.out.println(e.getSimpleName() + " " + e.getKind());

openjdk · 2021-08-10T16:44:18Z

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8140442: Add getOutermostTypeElement to javax.lang.model utility class

Reviewed-by: jlahoda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

67869b4: 8270137: Kerberos Credential Retrieval from Cache not Working in Cross-Realm Setup
35b399a: 8269130: Replace usages of Collection.toArray() with Collection.toArray(T[]) to avoid redundant array copying
2b05fae: 8260262: Use common code in function unmap_shared() in perfMemory_posix.cpp
f2599ad: 8272196: Remove unused class ParStrongRootsScope
1f88134: 8271869: AArch64: build errors with GCC11 in frame::saved_oop_result
089e83b: 8266490: Extend the OSContainer API to support the pids controller of cgroups
2384e12: 8270098: ZGC: ZBarrierSetC2::clone_at_expansion fails with "Guard against surprises" assert
d53d94b: 8271925: ZGC: Arraycopy stub passes invalid oop to load barrier
3b899ef: 8272168: some hotspot runtime/logging tests don't check exit code
abdc107: 8270454: G1: Simplify region index comparison
... and 5 more: https://git.openjdk.java.net/jdk/compare/b53828b7c219f8f8fb22177bcc80b045ef7bad76...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

jddarcy · 2021-08-10T16:48:01Z

/integrate

openjdk · 2021-08-10T16:50:04Z

Going to push as commit 57ae9fb.
Since your change was applied there have been 15 commits pushed to the master branch:

67869b4: 8270137: Kerberos Credential Retrieval from Cache not Working in Cross-Realm Setup
35b399a: 8269130: Replace usages of Collection.toArray() with Collection.toArray(T[]) to avoid redundant array copying
2b05fae: 8260262: Use common code in function unmap_shared() in perfMemory_posix.cpp
f2599ad: 8272196: Remove unused class ParStrongRootsScope
1f88134: 8271869: AArch64: build errors with GCC11 in frame::saved_oop_result
089e83b: 8266490: Extend the OSContainer API to support the pids controller of cgroups
2384e12: 8270098: ZGC: ZBarrierSetC2::clone_at_expansion fails with "Guard against surprises" assert
d53d94b: 8271925: ZGC: Arraycopy stub passes invalid oop to load barrier
3b899ef: 8272168: some hotspot runtime/logging tests don't check exit code
abdc107: 8270454: G1: Simplify region index comparison
... and 5 more: https://git.openjdk.java.net/jdk/compare/b53828b7c219f8f8fb22177bcc80b045ef7bad76...master

Your commit was automatically rebased without conflicts.

openjdk · 2021-08-10T16:50:20Z

@jddarcy Pushed as commit 57ae9fb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

jddarcy added 4 commits August 4, 2021 11:29

Initial version pre-tests.

42c390e

Merge branch 'master' into JDK-8140442

81364eb

Merge branch 'master' into JDK-8140442

cc11d8c

Now with tests and javac Elements implementation.

a899041

openjdk bot added the compiler compiler-dev@openjdk.org label Aug 4, 2021

Appease jcheck.

bc1de3f

openjdk bot added the rfr Pull request is ready for review label Aug 4, 2021

openjdk bot added the csr Pull request needs approved CSR before integration label Aug 4, 2021

lahodaj approved these changes Aug 10, 2021

View reviewed changes

jddarcy added 2 commits August 10, 2021 09:30

Respond to review feedback and update copyright.

3ac0555

Merge branch 'master' into JDK-8140442

7f58ab5

openjdk bot removed the csr Pull request needs approved CSR before integration label Aug 10, 2021

openjdk bot added the ready Pull request is ready to be integrated label Aug 10, 2021

openjdk bot closed this Aug 10, 2021

openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 10, 2021

jddarcy deleted the JDK-8140442 branch December 9, 2021 18:42

	// Conceptual instanceof TypeElment check. If the
	// Conceptual instanceof TypeElement check. If the

8140442: Add getOutermostTypeElement to javax.lang.model utility class #5007

8140442: Add getOutermostTypeElement to javax.lang.model utility class #5007

Uh oh!

Conversation

jddarcy commented Aug 4, 2021 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Aug 4, 2021

Uh oh!

openjdk bot commented Aug 4, 2021

Uh oh!

jddarcy commented Aug 4, 2021

Uh oh!

openjdk bot commented Aug 4, 2021

Uh oh!

mlbridge bot commented Aug 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

lahodaj left a comment

Choose a reason for hiding this comment

Uh oh!

lahodaj Aug 10, 2021

Choose a reason for hiding this comment

Uh oh!

jddarcy Aug 10, 2021

Choose a reason for hiding this comment

Uh oh!

lahodaj Aug 10, 2021

Choose a reason for hiding this comment

Uh oh!

openjdk bot commented Aug 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jddarcy commented Aug 10, 2021

Uh oh!

openjdk bot commented Aug 10, 2021

Uh oh!

openjdk bot commented Aug 10, 2021

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

jddarcy commented Aug 4, 2021 •

edited by openjdk bot

Loading

mlbridge bot commented Aug 4, 2021 •

edited

Loading

openjdk bot commented Aug 10, 2021 •

edited

Loading