Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8140442: Add getOutermostTypeElement to javax.lang.model utility class #5007

Closed
wants to merge 7 commits into from

Conversation

jddarcy
Copy link
Member

@jddarcy jddarcy commented Aug 4, 2021

Please review this change to add a getOutermostTypeElement method to javax.lang.model.Elements along with the corresponding CSR https://bugs.openjdk.java.net/browse/JDK-8271903.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8140442: Add getOutermostTypeElement to javax.lang.model utility class

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5007/head:pull/5007
$ git checkout pull/5007

Update a local copy of the PR:
$ git checkout pull/5007
$ git pull https://git.openjdk.java.net/jdk pull/5007/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5007

View PR using the GUI difftool:
$ git pr show -t 5007

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5007.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 4, 2021

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 4, 2021

@jddarcy The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler compiler-dev@openjdk.org label Aug 4, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 4, 2021
@jddarcy
Copy link
Member Author

jddarcy commented Aug 4, 2021

/csr needed

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Aug 4, 2021
@openjdk
Copy link

openjdk bot commented Aug 4, 2021

@jddarcy this pull request will not be integrated until the CSR request JDK-8271903 for issue JDK-8140442 has been approved.

@mlbridge
Copy link

mlbridge bot commented Aug 4, 2021

Webrevs

Copy link
Contributor

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me, looks good, with some nits inlined.

// This implementation is susceptible to infinite loops
// for misbehaving element implementations.
while (true) {
// Conceptual instanceof TypeElment check. If the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit:

Suggested change
// Conceptual instanceof TypeElment check. If the
// Conceptual instanceof TypeElement check. If the

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits fixed; thanks for the review.


@Override
public Void scan(Element e, Elements elts) {
// System.out.println(e.getSimpleName() + " " + e.getKind());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit:

Suggested change
// System.out.println(e.getSimpleName() + " " + e.getKind());

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Aug 10, 2021
@openjdk
Copy link

openjdk bot commented Aug 10, 2021

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8140442: Add getOutermostTypeElement to javax.lang.model utility class

Reviewed-by: jlahoda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • 67869b4: 8270137: Kerberos Credential Retrieval from Cache not Working in Cross-Realm Setup
  • 35b399a: 8269130: Replace usages of Collection.toArray() with Collection.toArray(T[]) to avoid redundant array copying
  • 2b05fae: 8260262: Use common code in function unmap_shared() in perfMemory_posix.cpp
  • f2599ad: 8272196: Remove unused class ParStrongRootsScope
  • 1f88134: 8271869: AArch64: build errors with GCC11 in frame::saved_oop_result
  • 089e83b: 8266490: Extend the OSContainer API to support the pids controller of cgroups
  • 2384e12: 8270098: ZGC: ZBarrierSetC2::clone_at_expansion fails with "Guard against surprises" assert
  • d53d94b: 8271925: ZGC: Arraycopy stub passes invalid oop to load barrier
  • 3b899ef: 8272168: some hotspot runtime/logging tests don't check exit code
  • abdc107: 8270454: G1: Simplify region index comparison
  • ... and 5 more: https://git.openjdk.java.net/jdk/compare/b53828b7c219f8f8fb22177bcc80b045ef7bad76...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 10, 2021
@jddarcy
Copy link
Member Author

jddarcy commented Aug 10, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Aug 10, 2021

Going to push as commit 57ae9fb.
Since your change was applied there have been 15 commits pushed to the master branch:

  • 67869b4: 8270137: Kerberos Credential Retrieval from Cache not Working in Cross-Realm Setup
  • 35b399a: 8269130: Replace usages of Collection.toArray() with Collection.toArray(T[]) to avoid redundant array copying
  • 2b05fae: 8260262: Use common code in function unmap_shared() in perfMemory_posix.cpp
  • f2599ad: 8272196: Remove unused class ParStrongRootsScope
  • 1f88134: 8271869: AArch64: build errors with GCC11 in frame::saved_oop_result
  • 089e83b: 8266490: Extend the OSContainer API to support the pids controller of cgroups
  • 2384e12: 8270098: ZGC: ZBarrierSetC2::clone_at_expansion fails with "Guard against surprises" assert
  • d53d94b: 8271925: ZGC: Arraycopy stub passes invalid oop to load barrier
  • 3b899ef: 8272168: some hotspot runtime/logging tests don't check exit code
  • abdc107: 8270454: G1: Simplify region index comparison
  • ... and 5 more: https://git.openjdk.java.net/jdk/compare/b53828b7c219f8f8fb22177bcc80b045ef7bad76...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 10, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 10, 2021
@openjdk
Copy link

openjdk bot commented Aug 10, 2021

@jddarcy Pushed as commit 57ae9fb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jddarcy jddarcy deleted the JDK-8140442 branch December 9, 2021 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler compiler-dev@openjdk.org integrated Pull request has been integrated
2 participants