Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271905: mark hotspot runtime/Metaspace tests which ignore external VM flags #5010

Closed
wants to merge 1 commit into from

Conversation

iignatev
Copy link
Member

@iignatev iignatev commented Aug 4, 2021

Hi all,

could you please review the patch that adds @requires vm.flagless to two runtime/Metaspace tests?

Thanks,
-- Igor


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8271905: mark hotspot runtime/Metaspace tests which ignore external VM flags

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5010/head:pull/5010
$ git checkout pull/5010

Update a local copy of the PR:
$ git checkout pull/5010
$ git pull https://git.openjdk.java.net/jdk pull/5010/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5010

View PR using the GUI difftool:
$ git pr show -t 5010

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5010.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 4, 2021

👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8271905 8271905: mark hotspot runtime/Metaspace tests which ignore external VM flags Aug 4, 2021
@openjdk openjdk bot added the rfr label Aug 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 4, 2021

@iignatev The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime label Aug 4, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 4, 2021

Webrevs

@tstuefe
Copy link
Member

@tstuefe tstuefe commented Aug 5, 2021

Hi Igor,

I know we spoke about this before, but could you please explain again the motivation for these changes? Is this flag somewhere documented?

AFAIU the flag changes the test such that it gets not executed by the jtreg framework if I specify a VM option on the command line with -vmoption (apart from a very narrow range of allowed options)?

I often run jtreg tests with additional options to exercise tests in different contexts. Having them quietly turn off themselves would not be helpful then.

Thanks, Thomas

@tstuefe
Copy link
Member

@tstuefe tstuefe commented Aug 5, 2021

@dholmes-ora explained this to me (spawning childs without the given vmoptions) so this makes sense to me. Unfortunately, duplication of ML mails into github still seems broken.

tstuefe
tstuefe approved these changes Aug 5, 2021
Copy link
Member

@tstuefe tstuefe left a comment

LGTM

@openjdk
Copy link

@openjdk openjdk bot commented Aug 5, 2021

@iignatev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271905: mark hotspot runtime/Metaspace tests which ignore external VM flags

Reviewed-by: stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 41 new commits pushed to the master branch:

  • 64d18d4: 4819544: SwingSet2 JTable Demo throws NullPointerException
  • 6c8441f: 8271878: UnProblemList jdk/jfr/event/gc/detailed/TestEvacuationFailedEvent.java in JDK18
  • 7728423: 8271895: UnProblemList javax/swing/JComponent/7154030/bug7154030.java in JDK18
  • cd6b54e: Merge
  • cebcc07: 8271894: ProblemList javax/swing/JComponent/7154030/bug7154030.java in JDK17
  • 5f547e8: 8271877: ProblemList jdk/jfr/event/gc/detailed/TestEvacuationFailedEvent.java in JDK17
  • 181483b: 8271064: ZGC several jvm08 perf regressions after JDK-8268372
  • a007cb1: 8271863: ProblemList serviceability/sa/TestJmapCore.java on linux-x64 with ZGC
  • d62fbea: 8271898: disable os.release_multi_mappings_vm on macOS-X64
  • 359c708: 8271893: mark hotspot runtime/PerfMemDestroy/PerfMemDestroy.java test as ignoring external VM flags
  • ... and 31 more: https://git.openjdk.java.net/jdk/compare/0199b03eb3bd9ffe79b5193ff1792144b5c488f1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 5, 2021
@iignatev
Copy link
Member Author

@iignatev iignatev commented Aug 5, 2021

Thank you both Thomas and David.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Aug 5, 2021

Going to push as commit 3ab95d1.
Since your change was applied there have been 49 commits pushed to the master branch:

  • e2c5bfe: 8271308: (fc) FileChannel.transferTo() transfers no more than Integer.MAX_VALUE bytes in one call
  • 7234a43: 8271953: fix mis-merge in JDK-8271878
  • d7fc9e4: 8267840: Improve URLStreamHandler.parseURL()
  • 55bd52a: 8271840: Add simple Integer.toString microbenchmarks
  • 18dd4d4: 8271121: ZGC: stack overflow (segv) when -Xlog:gc+start=debug
  • 685fc3c: 8270903: sun.net.httpserver.HttpConnection: Improve toString
  • 4abe531: 8271722: [TESTBUG] gc/g1/TestMixedGCLiveThreshold.java can fail if G1 Full GC uses >1 workers
  • ea9a595: 8270058: Use Objects.check{Index,FromIndexSize} for java.desktop
  • 64d18d4: 4819544: SwingSet2 JTable Demo throws NullPointerException
  • 6c8441f: 8271878: UnProblemList jdk/jfr/event/gc/detailed/TestEvacuationFailedEvent.java in JDK18
  • ... and 39 more: https://git.openjdk.java.net/jdk/compare/0199b03eb3bd9ffe79b5193ff1792144b5c488f1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 5, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 5, 2021

@iignatev Pushed as commit 3ab95d1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@iignatev iignatev deleted the 8271905 branch Aug 5, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 1, 2021

Mailing list message from David Holmes on hotspot-runtime-dev:

Hi Thomas,

On 5/08/2021 2:35 pm, Thomas Stuefe wrote:

On Wed, 4 Aug 2021 22:56:25 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:

Hi all,

could you please review the patch that adds `@requires vm.flagless` to two `runtime/Metaspace` tests?

Thanks,
-- Igor

Hi Igor,

I know we spoke about this before, but could you please explain again the motivation for these changes? Is this flag somewhere documented?

AFAIU the flag changes the test such that it gets not executed by the jtreg framework if I specify a VM option on the command line with -vmoption (apart from a very narrow range of allowed options)?

I often run jtreg tests with additional options to exercise tests in different contexts. Having them quietly turn off themselves would not be helpful then.

These tests exec another VM which is not passed the flags you set so
setting them provides no additional testing of the core thing the test
is actually testing.

Cheers,
David

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 1, 2021

Mailing list message from Thomas Stüfe on hotspot-runtime-dev:

Ah, thanks a lot for the reminder. Makes sense then.

On Thu, Aug 5, 2021 at 7:48 AM David Holmes <david.holmes at oracle.com> wrote:

Hi Thomas,

On 5/08/2021 2:35 pm, Thomas Stuefe wrote:

On Wed, 4 Aug 2021 22:56:25 GMT, Igor Ignatyev <iignatyev at openjdk.org>
wrote:

Hi all,

could you please review the patch that adds `@requires vm.flagless` to
two `runtime/Metaspace` tests?

Thanks,
-- Igor

Hi Igor,

I know we spoke about this before, but could you please explain again
the motivation for these changes? Is this flag somewhere documented?

AFAIU the flag changes the test such that it gets not executed by the
jtreg framework if I specify a VM option on the command line with -vmoption
(apart from a very narrow range of allowed options)?

I often run jtreg tests with additional options to exercise tests in
different contexts. Having them quietly turn off themselves would not be
helpful then.

These tests exec another VM which is not passed the flags you set so
setting them provides no additional testing of the core thing the test
is actually testing.

Cheers,
David

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime integrated
2 participants