Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271895: UnProblemList javax/swing/JComponent/7154030/bug7154030.java in JDK18 #5012

Closed
wants to merge 1 commit into from

Conversation

JesperIRL
Copy link
Member

@JesperIRL JesperIRL commented Aug 5, 2021

This reverts commit cebcc07


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8271895: UnProblemList javax/swing/JComponent/7154030/bug7154030.java in JDK18

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5012/head:pull/5012
$ git checkout pull/5012

Update a local copy of the PR:
$ git checkout pull/5012
$ git pull https://git.openjdk.java.net/jdk pull/5012/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5012

View PR using the GUI difftool:
$ git pr show -t 5012

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5012.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 5, 2021

👋 Welcome back jwilhelm! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Aug 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 5, 2021

@JesperIRL To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • 2d
  • awt
  • beans
  • build
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah
  • sound
  • swing

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Looks good.

Thanks,
David

@openjdk
Copy link

@openjdk openjdk bot commented Aug 5, 2021

@JesperIRL This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271895: UnProblemList javax/swing/JComponent/7154030/bug7154030.java in JDK18

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 5, 2021
@JesperIRL
Copy link
Member Author

@JesperIRL JesperIRL commented Aug 5, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Aug 5, 2021

Going to push as commit 7728423.

@openjdk openjdk bot closed this Aug 5, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 5, 2021

@JesperIRL Pushed as commit 7728423.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@JesperIRL JesperIRL deleted the 8271895 branch Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated
2 participants