Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271896: Remove unnecessary top address checks in BOT #5013

Closed
wants to merge 1 commit into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Aug 5, 2021

Simple change of removing unnecessary top checks. I left the one HeapRegion::block_size as an assert, since it's outside BOT.

Test: hotspot_gc


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8271896: Remove unnecessary top address checks in BOT

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5013/head:pull/5013
$ git checkout pull/5013

Update a local copy of the PR:
$ git checkout pull/5013
$ git pull https://git.openjdk.java.net/jdk pull/5013/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5013

View PR using the GUI difftool:
$ git pr show -t 5013

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5013.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 5, 2021

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Aug 5, 2021
@openjdk
Copy link

openjdk bot commented Aug 5, 2021

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Aug 5, 2021
@mlbridge
Copy link

mlbridge bot commented Aug 5, 2021

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Lgtm.

@openjdk
Copy link

openjdk bot commented Aug 5, 2021

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271896: Remove unnecessary top address checks in BOT

Reviewed-by: tschatzl, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

  • 685fc3c: 8270903: sun.net.httpserver.HttpConnection: Improve toString
  • 4abe531: 8271722: [TESTBUG] gc/g1/TestMixedGCLiveThreshold.java can fail if G1 Full GC uses >1 workers
  • ea9a595: 8270058: Use Objects.check{Index,FromIndexSize} for java.desktop
  • 64d18d4: 4819544: SwingSet2 JTable Demo throws NullPointerException
  • 6c8441f: 8271878: UnProblemList jdk/jfr/event/gc/detailed/TestEvacuationFailedEvent.java in JDK18
  • 7728423: 8271895: UnProblemList javax/swing/JComponent/7154030/bug7154030.java in JDK18
  • cd6b54e: Merge
  • cebcc07: 8271894: ProblemList javax/swing/JComponent/7154030/bug7154030.java in JDK17
  • 5f547e8: 8271877: ProblemList jdk/jfr/event/gc/detailed/TestEvacuationFailedEvent.java in JDK17
  • 181483b: 8271064: ZGC several jvm08 perf regressions after JDK-8268372
  • ... and 12 more: https://git.openjdk.java.net/jdk/compare/221e4b9c61cd1c9c3f4c037589ba639541532910...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 5, 2021
@albertnetymk
Copy link
Member Author

albertnetymk commented Aug 6, 2021

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Aug 6, 2021

Going to push as commit c2b7fac.
Since your change was applied there have been 38 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 6, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 6, 2021
@openjdk
Copy link

openjdk bot commented Aug 6, 2021

@albertnetymk Pushed as commit c2b7fac.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the bot-top branch Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated
3 participants