Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271930: Simplify end_card calculation in G1BlockOffsetTablePart::verify #5015

Closed
wants to merge 2 commits into from

Conversation

@albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Aug 5, 2021

Simplify end_card calculation and some general cleanup.

Test: hotspot_gc


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8271930: Simplify end_card calculation in G1BlockOffsetTablePart::verify

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5015/head:pull/5015
$ git checkout pull/5015

Update a local copy of the PR:
$ git checkout pull/5015
$ git pull https://git.openjdk.java.net/jdk pull/5015/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5015

View PR using the GUI difftool:
$ git pr show -t 5015

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5015.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 5, 2021

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Aug 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 5, 2021

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the hotspot-gc label Aug 5, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 5, 2021

Webrevs

Loading

Copy link
Contributor

@tschatzl tschatzl left a comment

Lgtm apart from the minor comment typos.

Loading

@@ -714,7 +714,8 @@ void HeapRegion::verify(VerifyOption vo,
p += obj_size;
}

if (!is_empty()) {
// only regions in old generation contain valid BOT
Copy link
Contributor

@tschatzl tschatzl Aug 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please start the sentence with upper case and end with full stop.

Loading

Copy link
Member Author

@albertnetymk albertnetymk Aug 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 23, 2021

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271930: Simplify end_card calculation in G1BlockOffsetTablePart::verify

Reviewed-by: tschatzl, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 178 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Aug 23, 2021
Copy link
Member

@walulyai walulyai left a comment

Lgtm!

Loading

@albertnetymk
Copy link
Member Author

@albertnetymk albertnetymk commented Aug 24, 2021

Thanks for the review.

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 24, 2021

Going to push as commit 928b972.
Since your change was applied there have been 188 commits pushed to the master branch:

  • 7f80683: 8272783: Epsilon: Refactor tests to improve performance
  • 22ef4f0: 5015261: NPE may be thrown if JDesktopIcon is set to null on a JInternalFrame
  • 9bc0232: 8269223: -Xcheck:jni WARNINGs working with fonts on Linux
  • 2ff4c01: 8271600: C2: CheckCastPP which should closely follow Allocate is sunk of a loop
  • ad92033: 8272736: [JVMCI] Add API for reading and writing JVMCI thread locals
  • 709b591: 8272553: several hotspot runtime/CommandLine tests don't check exit code
  • 1884072: 8265253: javac -Xdoclint:all gives "no comment" warning for code that can't be commented
  • 594e516: 8272778: Consolidate is_instance and is_instance_inlined in java_lang_String
  • d542745: 8267894: Skip work for empty regions in G1 Full GC
  • 741f58c: 8272417: ZGC: fastdebug build crashes when printing ClassLoaderData
  • ... and 178 more: https://git.openjdk.java.net/jdk/compare/221e4b9c61cd1c9c3f4c037589ba639541532910...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Aug 24, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 24, 2021

@albertnetymk Pushed as commit 928b972.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@albertnetymk albertnetymk deleted the bot-old branch Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants