Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271939: Clean up primitive raw accessors in oopDesc #5017

Closed
wants to merge 2 commits into from

Conversation

rkennke
Copy link
Contributor

@rkennke rkennke commented Aug 5, 2021

We have some _raw accessors in oop.hpp and related code. Those are leftover from when Shenandoah required primitive barriers and are no longer needed. Their uses can be replaced with the regular accessors.

Testing:

  • tier1
  • tier2
  • hotspot_gc

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8271939: Clean up primitive raw accessors in oopDesc

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5017/head:pull/5017
$ git checkout pull/5017

Update a local copy of the PR:
$ git checkout pull/5017
$ git pull https://git.openjdk.java.net/jdk pull/5017/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5017

View PR using the GUI difftool:
$ git pr show -t 5017

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5017.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 5, 2021

👋 Welcome back rkennke! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 5, 2021
@openjdk
Copy link

openjdk bot commented Aug 5, 2021

@rkennke The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Aug 5, 2021
@mlbridge
Copy link

mlbridge bot commented Aug 5, 2021

Webrevs

@rkennke
Copy link
Contributor Author

rkennke commented Aug 5, 2021

/cc hotspot-gc

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Aug 5, 2021
@openjdk
Copy link

openjdk bot commented Aug 5, 2021

@rkennke
The hotspot-gc label was successfully added.

Copy link
Member

@eastig eastig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shipilev
Copy link
Member

shipilev commented Aug 5, 2021

Looking at the RFE that introduced these, I think loader_data_raw is also the candidate for removal?

@openjdk
Copy link

openjdk bot commented Aug 6, 2021

@rkennke This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271939: Clean up primitive raw accessors in oopDesc

Reviewed-by: stefank, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

  • 38ff85c: 8271461: CompileCommand support for hidden class methods
  • c495ede: 8272099: mark hotspot runtime/Monitor tests which ignore external VM flags
  • e882087: 8271904: mark hotspot runtime/ClassFile tests which ignore external VM flags
  • fa36e33: 8271513: support JavaThreadIteratorWithHandle replacement by new ThreadsList::Iterator
  • cc61520: 8270842: G1: Only young regions need to redirty outside references in remset.
  • f4cf2f7: 8272095: ProblemList java/nio/channels/FileChannel/Transfer2GPlus.java on linux-aarch64
  • 0aca4f7: 8271868: Warn user when using mac-sign option with unsigned app-image.
  • b6a19f1: 8271128: InlineIntrinsics support for 32-bit ARM
  • c2b7fac: 8271896: Remove unnecessary top address checks in BOT
  • e7b6f48: 8265602: -XX:DumpLoadedClassList should support custom loaders
  • ... and 15 more: https://git.openjdk.java.net/jdk/compare/685fc3c677cd0e71ef4443214ae14c7eed355140...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 6, 2021
@rkennke
Copy link
Contributor Author

rkennke commented Aug 9, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Aug 9, 2021

Going to push as commit a86ac0d.
Since your change was applied there have been 26 commits pushed to the master branch:

  • b84a9c7: 8271956: AArch64: C1 build failed after JDK-8270947
  • 38ff85c: 8271461: CompileCommand support for hidden class methods
  • c495ede: 8272099: mark hotspot runtime/Monitor tests which ignore external VM flags
  • e882087: 8271904: mark hotspot runtime/ClassFile tests which ignore external VM flags
  • fa36e33: 8271513: support JavaThreadIteratorWithHandle replacement by new ThreadsList::Iterator
  • cc61520: 8270842: G1: Only young regions need to redirty outside references in remset.
  • f4cf2f7: 8272095: ProblemList java/nio/channels/FileChannel/Transfer2GPlus.java on linux-aarch64
  • 0aca4f7: 8271868: Warn user when using mac-sign option with unsigned app-image.
  • b6a19f1: 8271128: InlineIntrinsics support for 32-bit ARM
  • c2b7fac: 8271896: Remove unnecessary top address checks in BOT
  • ... and 16 more: https://git.openjdk.java.net/jdk/compare/685fc3c677cd0e71ef4443214ae14c7eed355140...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 9, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 9, 2021
@openjdk
Copy link

openjdk bot commented Aug 9, 2021

@rkennke Pushed as commit a86ac0d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
5 participants