Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254010: GrowableArrayView::print fails to compile #502

Closed
wants to merge 1 commit into from

Conversation

@TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Oct 5, 2020

When adding some debugging code, I've noticed that the (currently unused) GrowableArrayView::print fails to compile. The fix is to use the %d format specifier for the int fields _len and _max and cast this to intptr_t.

Thanks,
Tobias


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8254010: GrowableArrayView::print fails to compile

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/502/head:pull/502
$ git checkout pull/502

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 5, 2020

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Oct 5, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 5, 2020

@TobiHartmann The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the hotspot label Oct 5, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 5, 2020

Webrevs

Loading

stefank
stefank approved these changes Oct 5, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 5, 2020

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8254010: GrowableArrayView::print fails to compile

Reviewed-by: stefank

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 289ae79: 8252998: ModuleWrapper.gmk doesn't consult include path

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Oct 5, 2020
@TobiHartmann
Copy link
Member Author

@TobiHartmann TobiHartmann commented Oct 6, 2020

@stefank, thanks for the review!

Loading

@TobiHartmann
Copy link
Member Author

@TobiHartmann TobiHartmann commented Oct 6, 2020

/integrate

Loading

@openjdk openjdk bot closed this Oct 6, 2020
@openjdk openjdk bot added integrated and removed ready labels Oct 6, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 6, 2020

@TobiHartmann Since your change was applied there have been 14 commits pushed to the master branch:

  • 6e61861: 8254046: Remove double semicolon introduced by JDK-8235521
  • 5d84e95: 8204256: improve jlink error message to report unsupported class file format
  • 4fe68f5: 8253426: jpackage is unable to generate working EXE for add-launcher configurations
  • c9d0407: 8253794: TestAbortVMOnSafepointTimeout never timeouts
  • f2f77f7: 8253761: Wrong URI syntax printed by jar --describe-module
  • b29e108: 8253944: Certain method references to VarHandle methods should fail
  • 88d75c9: 8156071: List.of: reduce array copying during creation
  • ea27a54: 8224509: Incorrect alignment in CDS related allocation code on 32-bit platforms
  • 4d29116: 8253433: Remove -XX:+Debugging product option
  • 81dae70: 8253948: Memory leak in ImageFileReader
  • ... and 4 more: https://git.openjdk.java.net/jdk/compare/9604ee82690f89320614b37bfef4178abc869777...master

Your commit was automatically rebased without conflicts.

Pushed as commit 1728547.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@openjdk openjdk bot removed the rfr label Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants